Problem/Motivation

#3326239: Add phpstan/phpstan-phpunit as a dev dependency updated the PHPStan coverage to include better knowledge of PHPUnit, and our tests were lacking

Steps to reproduce

Proposed resolution

Remaining tasks

  • ✅ File an issue about this project
  • ☐ Manual Testing
  • ☐ Code Review
  • ☐ Accessibility Review
  • ☐ Automated tests needed/written?

Issue fork project_browser-3351137

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tim.plunkett created an issue. See original summary.

tim.plunkett opened merge request !365

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Needs review
chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Status: Needs review » Reviewed & tested by the community

Whoosh! Simple, and passing.

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented

  • tim.plunkett committed 6452d2c0 on 1.0.x 
    Issue #3351137 by tim.plunkett: Update tests for compatibility with...
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Reviewed & tested by the community » Fixed

Went ahead and merged it

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.