Drupal 10 compatibility

The patch applies successfully, except on the .info.yml file at line #5 on

core_version_requirement

,

range_slider.info.yml.rej:

--- range_slider.info.yml	(revision 7c067925566449a7e7830c746fc3dde7a108ba1a)
+++ range_slider.info.yml	(date 1677972525355)
@@ -2,4 +2,4 @@
 type: module
 description: Integration with https://rangeslider.js.org
 core: 8.x
-core_version_requirement: ^8 || ^9
+core_version_requirement: ^8 || ^9 || ^10

Also while testing the patch I get a js error

Uncaught TypeError: $(...).find(...).findOnce is not a function

on `range_slider/js/range-slider.js:59`

The new replacement for the same is once.filter() as per this

Based on this I think the findOnce() can be replaced with the following line of code by making use of the once.filter()

const filteredElements = once.filter('rangeSlider','.form-type-range-slider input, .js-form-type-range-slider input');
        filteredElements.forEach(function () {
          $(this).rangeslider('destroy');
        })

Thanks all for your work on this. Could we please apply the changes via a fork merge request to ensure the tests run?

Moving back to "Needs work" as per #4.

@lazzyvn I tried testing the new MR, for some reason the diff.patch still fails on .info.yml file

--- range_slider.info.yml
+++ range_slider.info.yml
@@ -1,5 +1,4 @@
 name: Range Slider
 type: module
 description: Integration with https://rangeslider.js.org
-core: 8.x
-core_version_requirement: ^8 || ^9
+core_version_requirement: ^8.8 || ^9 || ^10

After manually changing the core_version_requirement and adding ^10 to it I tested it.
Findings:
Drupal Test Version: 10
Browsers Tested on: Chrome and Firefox

The module seems to work fine on both, see the attached screenshots.

However If you look at the element classes I did not find the class mentioned by you with double dash i.e
js-form-type--range-slider
I found 2 classes namely
js-form-type-range-slider& form-type--range-slider

Based on the screenshots when I click the submit button the value seems to update fine based on the position of the slider.

@lazzyvn I tested this patch on Drupal core version 9.5.9

The patch applies successfully,
On testing this range slider on a custom form,
There were no errors on console or php.

On submit the range slider returns the values as expected .

Sorry but the tests are still failing in the Merge Requests, so this can't be merged yet.

WRT #13 please apply changes onto a Merge Request as a Patch will fail to apply on Composer as you can see in both #3 and #13.

Bumping version given CR Remove jQuery dependency from the once feature, and we are to discard Core 8.x / core_version_requirement: ^8 compatibility in .info.yml

#19 Thanks for clarifying.

Sorry, I see now that the selector in patch #13 is correct, I was looking at Merge request !4

@baikho thanks for maintaining this module well. I have query there is any timeline when we are able to see stable version of range_slider for drupal 10?

@lazzyvn Test fail to apply this patch.

@baikho thanks for maintaining this module well. I have query there is any timeline when we are able to see stable version of range_slider for drupal 10?

#21, once my review remarks in Merge request !4 have been resolved and the tests pass. Thank you

Hi, just a little change to the patch because of "The 'core_version_requirement' constraint (^9.2 || ^10) requires the 'core' key not be set ..."

I manually tested updated Merge request !4, but it doesn't work and the slider doesn't render. In the meantime I'm going to take the changes only needed for D10 compatibility, please raise the other changes in a new issue as they need more work. Thank you