Problem/Motivation
Package Current Wanted Latest
prettier 2.8.0 2.8.8 2.8.8
stylelint 14.16.0 14.16.1 15.6.0
stylelint-config-standard 29.0.0 29.0.0 33.0.0
stylelint-order 5.0.0 5.0.0 6.0.3
Steps to reproduce
Proposed resolution
yarn add -D stylelint stylelint-config-standard stylelint-order
yarn upgrade prettier
yarn build:css
yarn lint:css
yarn prettier
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #35 | 3344087-35.patch | 127.54 KB | longwave |
| #31 | 3344087-31.patch | 127.6 KB | mherchel |
| #26 | 3344087-26.patch | 128.93 KB | longwave |
| #23 | interdiff.3344087.19-23.txt | 5.56 KB | longwave |
| #23 | 3344087-23.patch | 120.43 KB | longwave |
Comments
Comment #2
longwaveNeed to figure out what to do with these deprecations:
Comment #3
longwaveAs per https://stylelint.io/migration-guide/to-15 we can just delete these rules from stylelintrc.json.
Comment #4
smustgrave commentedAlways for updating.
Comment #5
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #6
longwaveRerolled for the latest versions
Comment #7
smustgrave commentedMoving back to RTBC
Assuming if updating the package broke it would of been caught by the build.
Comment #9
catchCommitted/pushed to 10.1.x, thanks!
Comment #10
longwaveComment #12
longwaveI'm reverting this. Stylelint 15 has removed opinionated stylistic rules from the standard config: https://github.com/stylelint/stylelint/blob/15.0.0/docs/migration-guide/...
I didn't realise that we used Stylelint to format CSS after PostCSS has done its work; this is no longer working as noticed in #3351619: Update PostCSS and postcss-preset-env for Drupal 10.1
Therefore, reverting this for now while we figure out what to do; we have to replace the
stylelintfixer in the PostCSS toolchain withprettier, maybe?Comment #13
longwaveSo, we can start using Prettier to format our CSS output instead of Stylelint. Prettier is more opinionated and less configurable, but the output is slightly cleaner then before, I feel.
Comment #14
longwaveNeeded to make some more changes in stylelintrc.json for the latest versions:
at-rule-empty-line-before: Prettier conflicts with Stylelint here, so we have to disable it; see https://github.com/prettier/stylelint-config-prettier/issues/140#issueco...number-leading-zerois deprecated, removedmedia-feature-range-notationis new in stylelint-config-standard 32string-quotesis deprecated, removedComment #15
longwaveReroll following #3351618: Update ESLint and related packages
Comment #16
smustgrave commentedFrom what I can tell majority of css changes are just spacing updates.
Did notice .css files changed from inline to
+.ui-icon-contact {
+ background-position: -192px -128px;
+}
But since Drupal uses aggregation imagine that's a non issue.
Comment #17
longwaveTagging for FEFM review as we are changing the build process a little. If accepted this will also need a change record.
Comment #18
mherchelSetting this back to NW based on the #15's code checks failing
From the output (https://dispatcher.drupalci.org/job/drupal_patches/177539/consoleText), I see
Comment #19
gauravvvv commentedThere were some whitespace issues in
core/themes/claro/css/components/progress.cssfile. I have provided the patch and interdiff for same.Comment #20
mherchelThis looks great!
I went through the code (including all of the CSS changes) and didn't see anything out-of-line. I also tested the script locally running both
yarn build:cssandyarn lint:csswithout any changes (or issues).Comment #21
longwaveAdded a change notice: https://www.drupal.org/node/3353460
Comment #22
spokjeNeeds a reroll, unsure why TestBot didn't kick this back to NR.
Comment #23
longwaveRerolled and updated to yet more new versions of stylelint and stylelint-config-standard. This also means fixing a duplicate
transitionin Umami's search.css in order to pass linting again.Comment #24
mherchelWeird error coming from the test bot:
Comment #25
spokjeNeeds a reroll after #3343212: Update Core CSS to use double-colon for pseudo elements landed.
Comment #26
longwaveRerolled, upgraded Stylelint again, and as we are using Prettier here I upgraded that as well - no changes to the build output or to the JavaScript if I run
yarn prettier.Comment #27
longwaveComment #28
mherchelThis looks perfect (pending tests)!
I verified the only changes in the CSS are minor white-space changes (adding/removing lines, spacing inside of
calc(), and spacing next to comments).I also verified the
yarn build,yarn build:css,yarn lint:css, andyarn watch:csscommands work as expected, and don't generates results that differ from whats in the patch.Comment #29
mherchelAdding tag for Midcamp, since I reviewed that while attending :)
Comment #30
catchThis needs yet another re-roll for yarn.lock changes.
Comment #31
mherchelFixed the conflict in the yarn.lock file. Not really sure how to generate a useful interdiff, though. I had to apply the changes before a prev commit, stash / apply them and fix the file.
Setting back to NR
Comment #32
catchBack to RTBC pending the test run.
Comment #33
catchAnd again... We might need to schedule this one and avoid other CSS patches around a commit window if this keeps happening.
Comment #34
catchComment #35
longwaveReroll, patch applied with fuzz, rebuilt with yarn build:css to be sure but there were no changes.
Comment #37
catchGoing to be bold and commit this while the iron's hot (i.e. while tests are still running).
Committed 53f1304 and pushed to 10.1.x. Thanks!
Comment #38
quietone commentedI published the change record.