Allow non admin users to ignore 404 pages

+++ b/modules/redirect_404/src/Controller/Fix404IgnoreController.php
@@ -60,26 +60,37 @@ class Fix404IgnoreController extends ControllerBase {
     $langcode = $request->query->get('langcode');
 
-    if (empty($ignored_paths) || !strpos($path, $ignored_paths)) {
+    $editable = $this->configuration->getEditable('redirect_404.settings');
+    $existing_config_raw = $editable->get('pages');
+    if (!empty($existing_config_raw) && !strpos($path, $existing_config_raw)) {
+      $existing_config = explode(PHP_EOL, $existing_config_raw);
+      foreach ($existing_config as $key => $item) {
+        $existing_config[$key] = trim($item);
+      }
+      $existing_config[] = $path;
+
+      $ignored_paths = implode(PHP_EOL, array_filter($existing_config)) . PHP_EOL;
+      $editable->set('pages', $ignored_paths);
+      $editable->save();
+
       $this->redirectStorage->resolveLogRequest($path, $langcode);
 

I frequently change the provided pattern and instead make it a wildcard, I think it makes sense to keep the behavior for admins for now. Maybe two separate operations (ignore and customize..) or something could make sense, we can look into that later.

1. +++ b/modules/redirect_404/src/Controller/Fix404IgnoreController.php
   @@ -67,19 +67,42 @@ class Fix404IgnoreController extends ControllerBase {
        if (empty($ignored_paths) || !strpos($path, $ignored_paths)) {
          $this->redirectStorage->resolveLogRequest($path, $langcode);
   

   there is another langcode argument here that I think we should drop in the the other issue. Will probably conflict though, lets get one in and then reroll the other.

2. +++ b/modules/redirect_404/src/Controller/Fix404IgnoreController.php
   @@ -67,19 +67,42 @@ class Fix404IgnoreController extends ControllerBase {
   +      // Users without 'administer redirect settings' and 'ignore 4040 request'
   +      // permission can also ignore pages, but are not redirected to the
   +      // settings page, but save config directly.
   +      if (!$this->currentUser()->hasPermission('administer redirect settings') && $this->currentUser()->hasPermission('ignore 404 requests')) {
   +        $editable = $this->configuration->getEditable('redirect_404.settings');
   +        $existing_config_raw = $editable->get('pages');
   +        $existing_config = explode(PHP_EOL, $existing_config_raw);
   +
   +        foreach ($existing_config as $key => $item) {
   +          $existing_config[$key] = trim($item);
   +        }
   

   The "but save config directly" sounds strange, also due to two "but" in a row. I think we can possibly just drop that part, seems pretty clear.

   Also, maybe just get the editable config from the start

   And yes, we definitely need tests, because I don't actually see you adding the new path to the list, you just trim the existing ones and then save them back. I don't think we need that loop at all, if you look at redirect_404_form_redirect_settings_form_alter(), we just add the new one to the list, can't we do the same here?

Committed.