Problem/Motivation

Follow-up to #3342975-5: Deprecate Url::toRenderArray() and Url::renderAccess() - methods are deprecated and should be removed in 11.0.x as it's open

Proposed resolution

Remove following
- \Drupal\Core\Url::toRenderArray()
- \Drupal\Core\Url::renderAccess()
- \Drupal\Core\Url::trustedCallbacks() - probably should return empty array

Remaining tasks

- discuss removal of \Drupal\Core\Url::trustedCallbacks()
- patch/review/commit

User interface changes

no

API changes

no

Data model changes

no

Release notes snippet

CommentFileSizeAuthor
#9 3343153-9.patch4.19 KBsamitk
#13 3343153-nr-bot.txt2 KBneeds-review-queue-bot

Issue fork drupal-3343153

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

andypost created an issue. See original summary.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue tags: +Deprecation Removal
ankitv18’s picture

ankitv18 commented
Assigned: Unassigned » ankitv18
andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Postponed » Active
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Title: Remove deprecated code from \Drupal\Core\Url » [11.x] Remove deprecated code from \Drupal\Core\Url
Version: 11.0.x-dev » 11.x-dev
Issue tags: +Major version only

Updating title, tags and version number based on recent announcement at https://www.drupal.org/about/core/blog/new-drupal-core-branching-scheme-...

quietone’s picture

quietone commented
Title: [11.x] Remove deprecated code from \Drupal\Core\Url » Remove deprecated code from \Drupal\Core\Url
Parent issue: #3342975: Deprecate Url::toRenderArray() and Url::renderAccess() » #3295574: [meta] Remove deprecated classes, methods, procedural functions and code paths outside of deprecated modules on the Drupal 11 branch
Related issues: +#3342975: Deprecate Url::toRenderArray() and Url::renderAccess()

shivamsen_12579 made their first commit to this issue’s fork.

samitk’s picture

samitk commented
Assigned: ankitv18 » samitk
Status: Active » Needs work
samitk’s picture

samitk commented
Assigned: samitk » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3343153-9.patch4.19 KB

HI,

Deprecated code from \Drupal\Core\Url has been removed. Please review.

Thanks
Samit K.

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work

The Needs Review Queue Bot tested this issue.

While you are making the above changes, we recommend that you convert this patch to a merge request. Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)

samit.310@gmail.com opened merge request !6950

samitk’s picture

samitk commented
Status: Needs work » Needs review

Merge requests is created.

https://git.drupalcode.org/project/drupal/-/merge_requests/6950

Thanks
Samit K.

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 3343153-nr-bot.txt2 KB

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

samitk’s picture

samitk commented
Status: Needs work » Needs review
karanpagare’s picture

karanpagare commented

Changes are as per the proposed resolution. Needs further review from @andypost.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

All deprecated code from this file has been removed

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work

We never discussed the removal of \Drupal\Core\Url::trustedCallbacks() as per the issue summary.

Can we get a follow-up to remove the method and the interface from this class - then we can proceed here and discuss that on another issue.

smustgrave’s picture

smustgrave commented
Status: Needs work » Reviewed & tested by the community

Opened #3442684: Discuss removal of \Drupal\Core\Url::trustedCallbacks()

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x, thanks!

  • catch committed eceeb8f6 on 11.x 
    Issue #3343153 by samit.310@gmail.com, andypost, smustgrave, alexpott:...
catch’s picture

catch
he/him
Primary language English
commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.