Problem/Motivation
#3325869: Improve documentation for package_manager_bypass test module renamed a bunch of classes, one of which we use.
Steps to reproduce
Run tests, see fail.
Proposed resolution
Switch to new names
Consider opening a follow-up issue now that those new classes are marked @internal
Remaining tasks
- ✅ File an issue about this project
- ☐ Manual Testing
- ☐ Code Review
- ☐ Accessibility Review
- ☐ Automated tests needed/written?
Issue fork project_browser-3342218
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
wim leersWoah!
Project Browser was subclassing/overriding classes of a test-only module?! 😳No, it was just interacting with the decorated beginner & committer. That makes sense 👍 That change indeed happened in #3325869: Improve documentation for package_manager_bypass test module. Your changes look solid 👍But the remaining failures are all for
setFixturePath()calls that fail because it doesn't exist. That's been the case since #3332256: package_manager_bypass should *minimally* bypass php-tuf/composer-stager, not maximally, which was a crucial change to make the tests match reality rather than an almost complete simulation (which in many ways was disconnected from reality).Comment #4
tim.plunkettAh, we only just started failing tests now (and not in January when #3332256: package_manager_bypass should *minimally* bypass php-tuf/composer-stager, not maximally was fixed) because there was a new release of AU 2 days ago, and our ^2.6 constraint pulled in 2.7
Comment #6
tim.plunkett