Problem/Motivation

Hi @clivesj Thank you for revising the 3254557 patch and adding it into 3.1.x branch.

There is a logic condition bug in /src/File/DisplayFileList.php. So the external url of the Ad hoc public path is not shown up.

Steps to reproduce

Proposed resolution

diff --git a/src/File/DisplayFileList.php b/src/File/DisplayFileList.php
index b004904..1abf0ed 100644
--- a/src/File/DisplayFileList.php
+++ b/src/File/DisplayFileList.php
@@ -362,7 +362,7 @@ class DisplayFileList extends ControllerBase {
     }
     else {
       $settings = $this->filebrowser;
-      if ($settings->downloadManager == 'server') {
+      if ($settings->downloadManager == 'public') {
         $file_uri = $this->filebrowser->folderPath . $file->relativePath;
         $stream_wrapper = \Drupal::service('stream_wrapper_manager')
           ->getViaUri($file_uri);

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 3336136-02.patch584 bytesjamesyao

Comments

jamesyao created an issue. See original summary.

jamesyao’s picture

StatusFileSize
new584 bytes

  • clivesj committed b1592e82 on 3.1.x authored by jamesyao
    Issue #3336136 by jamesyao: The external URLs are not shown in the...
clivesj’s picture

Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.