A custom feature needs to display the external URLs for uploaded files in the public folder

Thanks.
This is a nice enhancement. Any chance you can provide a patch for the 3.x branch?
There not much diff with 8.x but 8.x is strictly for D8 and 3.x only for D9.

I am a bit busy and cannot produce a patch.
Can you please look at the following:
1. Filebrowser.settings.yml format for the new setting:
adhoc_settings:
external_host: ' '

2. We also need HOOK_N in the install file to update the module configuration for adhoc_settings.

3. Please correct typo exnternal.

4. On the config form we need a better description than “leave open, it is for a special feature”. It should be descriptive for other users.
5. We need description documenting what the new feature does to include in the readme.

Thanks for your time.

@jamesyao,

please replace deprecated db_add_field as follows:
https://api.drupal.org/api/drupal/core%21includes%21database.inc/functio...

also, please replace filebrowser_update_7100 with filebrowser_update_9001 as 3.0.x is D9+

and then change

function filebrowser_schema() {
  $schema['filebrowser_nodes'] = [
    'description' => 'Stores filebrowser specific data for each node',
    'fields' => [
      'nid' => [
        'type' => 'int',
        'unsigned' => TRUE,
        'not null' => TRUE,
        'description' => 'nid of the node holding this filebrowser',
      ],
      'folder_path' => [
        'type' => 'varchar',
        'length' => '255',
        'not null' => TRUE,
        'description' => 'uri to the exposed directory',
      ],
      'properties' => [
        'type' => 'text',
        'not null' => TRUE,
        'size' => 'big',
        'description' => 'serialised data containing the filebrowser settings for this node',
      ]
    ],
    'primary key' => ['nid']
  ];

to

function filebrowser_schema() {
  $schema['filebrowser_nodes'] = [
    'description' => 'Stores filebrowser specific data for each node',
    'fields' => [
      'nid' => [
        'type' => 'int',
        'unsigned' => TRUE,
        'not null' => TRUE,
        'description' => 'nid of the node holding this filebrowser',
      ],
      'folder_path' => [
        'type' => 'varchar',
        'length' => '255',
        'not null' => TRUE,
        'description' => 'uri to the exposed directory',
      ],
      'properties' => [
        'type' => 'text',
        'not null' => TRUE,
        'size' => 'big',
        'description' => 'serialised data containing the filebrowser settings for this node',
      ],
      'externalhost' => [
        'type' => 'varchar',
        'description' => "External host",
        'length' => 256,
        'not null' => FALSE,
      ]
    ],
    'primary key' => ['nid']
  ];

also, please recall that the php >=5.4 array syntax must be used
so rather than

$example = array('example', 'example2');

please use the expected Drupal 9 standard array style introduced in php 5.4:

$example = ['example', 'example2'];

The patch is working as described, and solves 200% of my customer's request.

I tend to split this patch into two task
1. display the file's urls as absolute Urls into the filessystem so that the webserver can deliver it directly (This is what my customer wants) This has the effect that the urls will remain persistent if a file is replaced, so the files can be referred externally. This could be archived by adding a new `Download manager`

2. Replace the host-part of the url with the configured `external_host`,

Some reviews on the patch:

+++ b/filebrowser.install
@@ -115,3 +123,22 @@ function filebrowser_schema() {
+  if ($some_error_condition_met) {
+    throw new UpdateException('Something went wrong; here is what you should do.');
+  }

Hmm, this is uneccessary code, the variable is not defined and the message is not helpful, I guess it's some generated code

+++ b/src/File/DisplayFileList.php
@@ -350,7 +353,29 @@ class DisplayFileList extends ControllerBase {
+      $externalhost = $config['adhocsetting']['externalhost'];
+      $directoryuri = $this->filebrowser->folderPath;
+      if (isset($externalhost) && (!empty($externalhost)) && (strpos($directoryuri, 'public://') !== false)) {
+        $publicfolderpath =  Settings::get('file_public_path');
+        if (!isset($publicfolderpath)) {
+          $publicfolderpath = PublicStream::basePath();
+        }
+        $publicfolderpath = '/' . $publicfolderpath. '/';
+        $publicfolderpath = str_replace('public://', $publicfolderpath, $directoryuri);
+        $fexternal_url = $externalhost . $publicfolderpath . $file->relativePath;
+        $fexternal_link = Link::fromTextAndUrl($name, Url::fromUri($fexternal_url));
+        if (isset($fexternal_link)) {
+          return $fexternal_link;

This part should use the Streamwrappers, so that the generation is not restricted to the public wrapper.

As outlined in #16 I expanded the download_manager (I'm not totally convinced, that the naming is still valid, but it's good enough) with a `server` manager. Whenever this is selected a the link points to a file not to the file-entity.

When an `external host` is configured the `scheme&host` part of the url is replaced with the configured value.

The url is generated with the help of the used streamwrapper, this allows to use custom `flysystems` wrappers.

The previous patch got the `external host`from filebrowser's configuration, not from the displayed node, I changed this, it seems to make more sense.

The file `DisplayFileList.php` is reformatted with `phpcbf`there are still code-style-issues that have to be fixed manually.

Arghh path #17 is an interdiff, don't use it, correct path and the interdiff attached here.

pacht #18 does not apply with latest dev Version

The patch is against latest 3.1.x-dev
I have included code to update current configuration for the new setting.
dev is updated and if commit holds, I can make a new release 3.1.0 which has this new feature and is also D10 compatible.