Prepare Smart IP for Drupal 10 [#3332499]

Comment	File	Size	Author
#37	3332499-37.patch	3.19 KB	heddn

Comment #1

11 January 2023 at 02:57

arpeggio created an issue. See original summary.

Log in or register to post comments

Comment #2

arpeggio commented 11 January 2023 at 02:58

Issue summary:

View changes

Log in or register to post comments

Comment #34

arpeggio commented 4 March 2023 at 00:39

Status:

Active

» Fixed

Log in or register to post comments

Thanks arpeggio for your work on getting smart_ip ready for Drupal 10. Installing 5.0.0-alpha2 still fails though, because it has a dependency to drupal/core ^9 in composer.json. Is this dependency even necessary?

 ],
  "require": {
    "drupal/core": "^8.7.7 || ^9",
    "geoip2/geoip2": "~2.0",
    "ip2location/ip2location-php": "~8.0"
  },
]

Log in or register to post comments

Comment #36

heddn

English

Nicaragua

commented 13 March 2023 at 17:48

Status:

Fixed

» Needs work

NW because of #35.

Log in or register to post comments

Comment #37

heddn

English

Nicaragua

commented 13 March 2023 at 18:27

Status:

Needs work

» Needs review

Status	File	Size
new	3332499-37.patch	3.19 KB

This adds a test and does minimal changes to get them passing or fix some odd findings from phpstan.

Log in or register to post comments

Comment #38

darvanen

he/him

English

Sydney, Australia

commented 5 May 2023 at 06:01

Code looks good to me, came here because I found the same issue with composer.json.

I note the submodules also have composer.json files with references to drupal/core - should those be updated too?

Log in or register to post comments

Comment #39

heddn

English

Nicaragua

commented 28 June 2023 at 21:49

Please also refer to #3348210: definition of getGeolocation(string $ipAddress) in sub-module missing 'array' and #3304799: Trim with null (deprecated/error) PHP 8.1. Which are also needed to get PHP 8.1 support (required for Drupal 10).

Log in or register to post comments

Comment #40

heddn

English

Nicaragua

commented 28 June 2023 at 21:52

Closed out the following as duplicates to this.

Log in or register to post comments

Comment #41

4 August 2023 at 15:11

heddn committed c3aa32ce on 8.x-4.x

Issue #3332499 by heddn, arpeggio: Prepare Smart IP for Drupal 10

Log in or register to post comments

Comment #42

4 August 2023 at 15:11

arpeggio committed 397a5369 on 8.x-4.x

Issue #3332499 by arpeggio: Update smart_ip.info.yml

Log in or register to post comments

Comment #43

4 August 2023 at 15:11

arpeggio committed dcaddda9 on 8.x-4.x

Issue #3332499 by arpeggio: Update WebServiceUtility.php

Log in or register to post comments

Comment #44

4 August 2023 at 15:11

arpeggio committed d1256f5e on 8.x-4.x

Issue #3332499 by arpeggio: Update SmartIpEventSubscriber.php

Log in or register to post comments

Comment #45

4 August 2023 at 15:11

arpeggio committed b556490c on 8.x-4.x

Issue #3332499 by arpeggio: Update smart_ip_maxmind_geoip2_web_service....

Log in or register to post comments

Comment #46

4 August 2023 at 15:11

arpeggio committed d73cb711 on 8.x-4.x

Issue #3332499 by arpeggio: Update SmartIpEventSubscriber.php

Log in or register to post comments

Comment #47

4 August 2023 at 15:11

arpeggio committed 3c058455 on 8.x-4.x

Issue #3332499 by arpeggio: Update DatabaseFileUtility.php

Log in or register to post comments

Comment #48

4 August 2023 at 15:11

arpeggio committed e768b610 on 8.x-4.x

Issue #3332499 by arpeggio: Update smart_ip_maxmind_geoip2_bin_db....

Log in or register to post comments

Comment #49

4 August 2023 at 15:11

arpeggio committed ffc785da on 8.x-4.x

Issue #3332499 by arpeggio: Update smart_ip_maxmind_geoip2_bin_db.info....

Log in or register to post comments

Comment #50

4 August 2023 at 15:11

arpeggio committed 5409d07a on 8.x-4.x

Issue #3332499 by arpeggio: Update WebServiceUtility.php

Log in or register to post comments

Comment #51

4 August 2023 at 15:11

arpeggio committed 453d7384 on 8.x-4.x

Issue #3332499 by arpeggio: Update SmartIpEventSubscriber.php

Log in or register to post comments

Comment #52

4 August 2023 at 15:11

arpeggio committed a00867ff on 8.x-4.x

Issue #3332499 by arpeggio: Update smart_ip_ipinfodb_web_service.info....

Log in or register to post comments

Comment #53

4 August 2023 at 15:11

arpeggio committed 2855ca92 on 8.x-4.x

Issue #3332499 by arpeggio: Update Ip2locationBinDb.php

Log in or register to post comments

Comment #54

4 August 2023 at 15:11

arpeggio committed f2a622c9 on 8.x-4.x

Issue #3332499 by arpeggio: Update /SmartIpEventSubscriber.php

Log in or register to post comments

Comment #55

4 August 2023 at 15:11

arpeggio committed f82a7848 on 8.x-4.x

Issue #3332499 by arpeggio: Update DatabaseFileUtility.php

Log in or register to post comments

Comment #56

4 August 2023 at 15:11

arpeggio committed 5b26dd6d on 8.x-4.x

Issue #3332499 by arpeggio: Update smart_ip_ip2location_bin_db.install

Log in or register to post comments

Comment #57

4 August 2023 at 15:11

arpeggio committed 9121abf7 on 8.x-4.x

Issue #3332499 by arpeggio: Update smart_ip_ip2location_bin_db.info.yml

Log in or register to post comments

Comment #58

4 August 2023 at 15:11

arpeggio committed 1d91089e on 8.x-4.x

Issue #3332499 by arpeggio: Update WebServiceUtility.php

Log in or register to post comments

Comment #59

4 August 2023 at 15:11

arpeggio committed 89df7b79 on 8.x-4.x

Issue #3332499 by arpeggio: Update SmartIpEventSubscriber.php

Log in or register to post comments

Comment #60

4 August 2023 at 15:11

arpeggio committed f729aff9 on 8.x-4.x

Issue #3332499 by arpeggio: Update smart_ip_abstract_web_service.info....

Log in or register to post comments

Comment #61

4 August 2023 at 15:11

arpeggio committed 07e6d043 on 8.x-4.x

Issue #3332499 by arpeggio: Update VisitorGeolocation.php

Log in or register to post comments

Comment #62

4 August 2023 at 15:11

arpeggio committed 9ed0e961 on 8.x-4.x

Issue #3332499 by arpeggio: Update SmartIpEventSubscriber.php

Log in or register to post comments

Comment #63

4 August 2023 at 15:11

arpeggio committed 3d0df8e5 on 8.x-4.x

Issue #3332499 by arpeggio: Update DeviceGeolocation.php

Log in or register to post comments

Comment #64

4 August 2023 at 15:11

arpeggio committed fdaf4962 on 8.x-4.x

Issue #3332499 by arpeggio: Update DeviceGeolocationController.php

Log in or register to post comments

Comment #65

4 August 2023 at 15:11

arpeggio committed 5a4b5d20 on 8.x-4.x

Issue #3332499 by arpeggio: Update device_geolocation.module

Log in or register to post comments

Comment #66

4 August 2023 at 15:11

arpeggio committed c591748e on 8.x-4.x

Issue #3332499 by arpeggio: Update device_geolocation.install

Log in or register to post comments

Comment #67

4 August 2023 at 15:11

arpeggio committed f62e6c4b on 8.x-4.x

Issue #3332499 by arpeggio: Update device_geolocation.info.yml

Log in or register to post comments

Comment #68

4 August 2023 at 15:11

arpeggio committed 3ae54b4e on 8.x-4.x

Issue #3332499 by arpeggio: Update UserCountry.php

Log in or register to post comments

Comment #69

4 August 2023 at 15:11

arpeggio committed c2251fe6 on 8.x-4.x

Issue #3332499 by arpeggio: Update SmartIpAdminSettingsForm.php

Log in or register to post comments

Comment #70

4 August 2023 at 15:11

arpeggio committed d42628d4 on 8.x-4.x

Issue #3332499 by arpeggio: Update EventSubscriber/...

Log in or register to post comments

Comment #71

4 August 2023 at 15:11

arpeggio committed 4f6c8ef6 on 8.x-4.x

Issue #3332499 by arpeggio: Update WebServiceUtilityInterface.php

Log in or register to post comments

Comment #72

4 August 2023 at 15:11

arpeggio committed 419cb381 on 8.x-4.x

Issue #3332499 by arpeggio: Update WebServiceUtilityBase.php

Log in or register to post comments

Comment #73

4 August 2023 at 15:11

arpeggio committed aaf7bd58 on 8.x-4.x

Issue #3332499 by arpeggio: Update SmartIp.php

Log in or register to post comments

Comment #74

4 August 2023 at 15:11

arpeggio committed 9412424c on 8.x-4.x

Issue #3332499 by arpeggio: Update SmartIpLocationInterface.php

Log in or register to post comments

Comment #75

4 August 2023 at 15:11

arpeggio committed 9f3157a1 on 8.x-4.x

Issue #3332499 by arpeggio: Update SmartIpEvents.php and SmartIpLocation...

Log in or register to post comments

Comment #76

4 August 2023 at 15:11

arpeggio committed d9190dd5 on 8.x-4.x

Issue #3332499 by arpeggio: Update SmartIpEventSubscriberBase.php

Log in or register to post comments

Comment #77

4 August 2023 at 15:11

arpeggio committed 4908b4ad on 8.x-4.x

Issue #3332499 by arpeggio: Update SmartIpDataSourceInterface.php

Log in or register to post comments

Comment #78

4 August 2023 at 15:11

arpeggio committed d9bdebff on 8.x-4.x

Issue #3332499 by arpeggio: Update GetLocationEvent.php

Log in or register to post comments

Comment #79

4 August 2023 at 15:11

arpeggio committed 5f12cab0 on 8.x-4.x

Issue #3332499 by arpeggio: Update DatabaseFileUtilityInterface.php

Log in or register to post comments

Comment #80

4 August 2023 at 15:11

arpeggio committed 482b7ec9 on 8.x-4.x

Issue #3332499 by arpeggio: Update DatabaseFileUtilityBase.php

Log in or register to post comments

Comment #81

4 August 2023 at 15:11

arpeggio committed 362dcc5c on 8.x-4.x

Issue #3332499 by arpeggio: Update DatabaseFileEvent.php

Log in or register to post comments

Comment #82

4 August 2023 at 15:11

arpeggio committed 9f77c4d2 on 8.x-4.x

Issue #3332499 by arpeggio: Update AdminSettingsEvent.php

Log in or register to post comments

Comment #83

4 August 2023 at 15:11

arpeggio committed 03330c6d on 8.x-4.x

Issue #3332499 by arpeggio: Update smart_ip.country_list.inc

Log in or register to post comments

Comment #84

4 August 2023 at 15:11

arpeggio committed be602e8f on 8.x-4.x

Issue #3332499 by arpeggio: Update smart_ip.install

Log in or register to post comments

Comment #85

4 August 2023 at 15:11

arpeggio committed fd2ea31b on 8.x-4.x

Issue #3332499 by arpeggio: Update smart_ip.module

Log in or register to post comments

Comment #86

4 August 2023 at 15:12

heddn committed 1b045d38 on 5.0.x

Issue #3332499 by heddn, arpeggio: Prepare Smart IP for Drupal 10

Log in or register to post comments

Comment #87

heddn

English

Nicaragua

commented 19 July 2024 at 21:05

Status:

Needs review

» Fixed

I think this should be marked as done.

Log in or register to post comments

Comment #88

2 August 2024 at 21:09

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Log in or register to post comments

Prepare Smart IP for Drupal 10

Problem/Motivation

Comments