Error message: Declaration of Drupal\\smart_ip_maxmind_geoip2_web_service\\WebServiceUtility::getGeolocation(?string $ipAddress = null) must be compatible with Drupal\\smart_ip\\WebServiceUtilityInterface::getGeolocation(string $ipAddress): array in ...smart_ip/modules/smart_ip_maxmind_geoip2_web_service/src/WebServiceUtility.php

Fix: 

-  public static function getGeolocation(string $ipAddress = NULL) {

+  public static function getGeolocation(string $ipAddress = NULL): array {

in WebServiceUtility.php in smart_ip_maxmind_geoip2_web_service and smart_ip_ipinfodb_web_service and smart_ip_ipinfodb_web_service

Issue fork smart_ip-3348210

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

John_B created an issue. See original summary.

mehul.gada made their first commit to this issue’s fork.

mehul.gada opened merge request !8

mehul.gada’s picture

mehul.gada
Primary language English
Location Mumbai
commented
Status: Active » Needs review

PHP warnings fixed as mentioned in Issue statement.

john_b’s picture

john_b commented
Status: Needs review » Reviewed & tested by the community

Thanks.

  • heddn committed 2d0c325b on 8.x-4.x 
    Issue #3348210 by mehul.gada, John_B, heddn: definition of...

  • heddn committed f87adc6f on 5.0.x 
    Issue #3348210 by mehul.gada, John_B, heddn: definition of...

poker10 credited heddn.

poker10’s picture

poker10 commented
Status: Reviewed & tested by the community » Fixed

I think this is already Fixed, as it was committed to 5.0.x and 8.x-4.x 9 months ago.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.