Problem/Motivation

At some point, in "smart_ip/src/SmartIp.php" file since

public static function query($ip = NULL)

accepts null value it could lead to

trim(): Passing null to parameter #1 ($string) of type string is deprecated in /web/modules/contrib/smart_ip/src/SmartIp.php line 30

and fatal error on execution

Steps to reproduce

Query with a null value / behat test

Proposed resolution

Check if value is null.

Remaining tasks

Fix

User interface changes

n/a

API changes

n/a (?)

Data model changes

n/a

Issue fork smart_ip-3304799

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

progzy created an issue. See original summary.

progzy’s picture

progzy commented
Issue summary: View changes

mehul.gada made their first commit to this issue’s fork.

mehul.gada opened merge request !2

mehul.gada’s picture

mehul.gada
Primary language English
Location Mumbai
commented
Status: Active » Needs review

Created MR with the fix for PHP 8.1 compatibility. Tested on local lando environment and seems to be working fine.

aporie’s picture

aporie
Primary language French
commented

Does the job, no problem. +1 for the review.

super_romeo’s picture

super_romeo commented

Works for me. Thank you @mehul.gada!

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Status: Needs review » Reviewed & tested by the community
Related issues: +#3348591: PHP 8.1 Update Issue

Actually, this is older. Closing #3348591: PHP 8.1 Update Issue as duplicate.

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Status: Reviewed & tested by the community » Closed (duplicate)
Related issues: +#3332499: Prepare Smart IP for Drupal 10

This was fixed by #3332499: Prepare Smart IP for Drupal 10.

heddn closed merge request !2