Problem/Motivation

#3287263: Automated Drupal 10 compatibility fixes was recently closed as fixed. But then within days #3238952: Migration missing for global settings landed that introduced code that won't work in Drupal 10. Lets fix that (and hopefully add test runners for Drupal 10 at the same time so regression doesn't re-surface).

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 3329868.patch1 KBheddn

Comments

heddn created an issue. See original summary.

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Issue tags: +Drupal 10 compatibility
  1. web/modules/contrib/entity_print/src/Event/FilenameAlterEvent.php 10 Class Drupal\entity_print\Event\FilenameAlterEvent extends deprecated class Symfony\Component\EventDispatcher\Event: since Symfony 4.3, use "Symfony\Contracts\EventDispatcher\Event" instead
  2. web/modules/contrib/entity_print/tests/src/Kernel/MigrateEntityPrintTest.php 28 Call to deprecated function drupal_get_path(). Deprecated in drupal:9.3.0 and is removed from drupal:10.0.0. Use Drupal\Core\Extension\ExtensionPathResolver::getPath() instead.
heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Status: Active » Needs review
StatusFileSize
new 3329868.patch1 KB
vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Status: Needs review » Reviewed & tested by the community

Thanks.
I'll issue emergency patch and we can sort tests afterwards.

  • VladimirAus committed b2d6c8ab on 8.x-2.x authored by heddn 
    Issue #3329868 by heddn, VladimirAus: Drupal 10 compatibility
heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Status: Reviewed & tested by the community » Fixed

Is this fixed then as it was committed?

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented

It is fixed.
Cheers @heddn 🥂

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

See also #3330943: Fix tests in HEAD on D10

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

I've fixed fails in head and cut another D10 release, we should be making sure we have green tests for both D9 and 10 before any new commits 👍️

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented

Cheers @larowlan! Great work 🍻

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.