Problem/Motivation

The "Unable to download modules via the UI" warning shows up regardless of source plugin, but some plugins such as Drupal Core , which handles modules already provided via core can install without Package Manager, so this warning is not relevant.

The warning should only be displayed on sources that use Package Manager.

Steps to reproduce

Proposed resolution

Remaining tasks

  • ✅ File an issue about this project
  • ☐ Manual Testing
  • ☐ Code Review
  • ☐ Accessibility Review
  • ☐ Automated tests needed/written?

Issue fork project_browser-3328124

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bnjmnm created an issue. See original summary.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Issue tags: +core-mvp
narendrar’s picture

narendrar
He/Him
Primary language English
Location Jaipur, India
commented
Assigned: Unassigned » narendrar
Status: Active » Needs work

narendraR opened merge request !336

narendrar’s picture

narendrar
He/Him
Primary language English
Location Jaipur, India
commented
Assigned: narendrar » Unassigned
Status: Needs work » Needs review
chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Status: Needs review » Needs work

When I rebase this, it seems to remove uiCapabilities from the stores.js - but this MR seems to still need it. It's a bit over my head, but I can at least say I'm not qualified to handle the rebase, so maybe @narendraR can take another peek.

fjgarlin’s picture

fjgarlin commented

Same here, I tried and got the same issue as Chris, it would also complain about ProjectButton. So I guess something went wrong with the rebase.

narendrar’s picture

narendrar
He/Him
Primary language English
Location Jaipur, India
commented
Status: Needs work » Needs review

I have done the required changes 🤞

fjgarlin’s picture

fjgarlin commented
Assigned: Unassigned » fjgarlin

Testing / reviewing.

fjgarlin’s picture

fjgarlin commented
Assigned: fjgarlin » Unassigned
Status: Needs review » Reviewed & tested by the community

Code is simple enough in both back-end and front-end and does exactly what's needed for this issue. Also, the code is propagated to the demo and tests plugins.

I tested via Drupalpod, saw the warning on mock issues and did not see it on core issues.

Marking RTBC.

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Status: Reviewed & tested by the community » Fixed

Thanks everyone!

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.