Problem/Motivation

We require a feature to control the email notification sending to the customers/license owners on license expiration.

Proposed resolution

A field(Checkbox) on Product Variation Type configuration page and validation in commerce_license_expire_notify Advanced Job Queue Type can accomplish this requirement.

CommentFileSizeAuthor
#9 allow-administrators-to-disable-email-notification-sending-on-license-expiration-3327540-9.patch5.15 KBvipin.j
#7 allow-administrators-to-disable-email-notification-sending-on-license-expiration-3327540-7.patch5.73 KBvipin.j
#6 allow-administrators-to-disable-email-notification-sending-on-license-expiration-3327540-6.patch5.99 KBvipin.j
#4 allow-administrators-to-disable-email-notification-sending-on-license-expiration-3327540-4.patch5.29 KBvipin.j
#2 allow-administrators-to-disable-email-notification-sending-on-license-expiration-3327540-2.patch2.99 KBvipin.j

Issue fork commerce_license-3327540

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

vipin.j created an issue. See original summary.

vipin.j’s picture

vipin.j commented
Status: Active » Needs review
StatusFileSize
new allow-administrators-to-disable-email-notification-sending-on-license-expiration-3327540-2.patch2.99 KB

Here is the patch to fulfill the requirement.

Status: Needs review » Needs work

The last submitted patch, 2: allow-administrators-to-disable-email-notification-sending-on-license-expiration-3327540-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

vipin.j’s picture

vipin.j commented
Status: Needs work » Needs review
StatusFileSize
new allow-administrators-to-disable-email-notification-sending-on-license-expiration-3327540-4.patch5.29 KB

Patch updated with missing dependencies.

Status: Needs review » Needs work

The last submitted patch, 4: allow-administrators-to-disable-email-notification-sending-on-license-expiration-3327540-4.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

vipin.j’s picture

vipin.j commented
StatusFileSize
new allow-administrators-to-disable-email-notification-sending-on-license-expiration-3327540-6.patch5.99 KB

Fixes testbot errors for 8.x-2.x-dev version.

vipin.j’s picture

vipin.j commented
Version: 8.x-2.x-dev » 8.x-2.0-beta2
StatusFileSize
new allow-administrators-to-disable-email-notification-sending-on-license-expiration-3327540-7.patch5.73 KB

We require a patch compatible with current release 8.x-2.0-beta2, the previously uploaded patches were compatible with 8.x-2.x-dev. this patch also fulfill the requirement of this issue but for current release.

vipin.j’s picture

vipin.j commented
Version: 8.x-2.0-beta2 » 8.x-2.x-dev
Status: Needs work » Needs review
vipin.j’s picture

vipin.j commented
Version: 8.x-2.x-dev » 3.0.x-dev
StatusFileSize
new allow-administrators-to-disable-email-notification-sending-on-license-expiration-3327540-9.patch5.15 KB

Patch #7 re-rolled for version 3.0.x-dev.

dercheffe’s picture

dercheffe
he/him
Primary language German
Location Sersheim, Germany
commented

Patch in #9 works fine for me in the dev version of commerce license thank you 🙏

I would suggest to change the job result from "failure" to "success" because it's a wanted result by design.

dercheffe’s picture

dercheffe
he/him
Primary language German
Location Sersheim, Germany
commented
Priority: Normal » Major
Status: Needs review » Reviewed & tested by the community

Set this to Major because this issue has impact on side-wide UX, because of sending emails to users without permission by admin.

goose2000’s picture

goose2000 commented

Hi, just reporting I was able to apply the patch #9 cleanly ( against 3.0.2 Stable release released 25 June 2025) and it does appear to be working well. This is on D 10.4.8 - using it in production.

Thank you all.

nojj’s picture

nojj commented

@gooese2000 thank you for reporting.
we have the same requirement now and it would be nice to have this feature integrated in a release of this module.

zaporylie’s picture

zaporylie
he/him
Primary language Polish
commented
Version: 3.0.x-dev » 3.x-dev

zaporylie opened merge request !31

zaporylie’s picture

zaporylie
he/him
Primary language Polish
commented
Status: Reviewed & tested by the community » Needs review

I extended test coverage and updated the logic slightly so no errors are found in advancedqueue log for disabled notifications. I also made sure license without variation doesn't WSOD

tbkot made their first commit to this issue’s fork.

jsacksick’s picture

jsacksick commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.