The simplemenu does not display on certain paths. This is caused by the condition logic in hook_init. The $theme variable is not available until after the theme system has been initialised.

I have corrected this by calling theme() which has the effect of initialising the theme system. I also removed a couple of needless globals and fixed the logic of the conditional so it works properly.

CommentFileSizeAuthor
simplemenu_theme_exclusion.patch723 bytespsynaptic

Comments

psynaptic’s picture

psynaptic commented

I should add that I tested it with a custom theme set from the user profile too and it works for me fine.

kndr’s picture

kndr
he/him
Primary language Polish
Location Rybnik, Poland
commented

It works for me. Thanks. I had strange problem with simplemenu and fckeditor on certain paged (especially in node/*/edit). Your solution solved it.

psynaptic’s picture

psynaptic commented
Status: Active » Reviewed & tested by the community

Thanks for testing! I hope this will be reviewed by the maintainer. :)

zroger’s picture

zroger commented
Status: Reviewed & tested by the community » Postponed (maintainer needs more info)

Calling any theme function in hook_init() is too early and disrupts normal theme initialization. #336119 is a result of this finding.

The extra global declarations have also been removed already. The conditional logic may still need to be changed.

Can you give a better description of the actual problem, and steps to recreate it.

jseffel’s picture

jseffel commented

I've also tested the patch and it worked for me. The menu didnt show up node node/nid, node/nid/edit but it does now.

zroger’s picture

zroger commented
Status: Postponed (maintainer needs more info) » Needs work

This patch needs work.

Point blank, any call to theme() in the init function breaks the theme system in other places, so there is no chance of this patch getting committed as is.

psynaptic’s picture

psynaptic commented

This came back when I updated simplemenu on a site I built a few weeks ago. I just removed:

(!isset($exclusions[$theme])) &&

..from line 35 and it's all working properly again now.

zroger’s picture

zroger commented
Status: Needs work » Fixed

you were definitely on the right track with $theme not being available in hook_init().

latest code only checks for theme from hook_footer().

zroger’s picture

zroger commented

Committed to 6.x-1.2

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.