Problem/Motivation

Even when Tippy.js is disabled on admin/structure/webform/config/libraries, the library is still loaded from unpkg.com on Webform administration pages and no CDN warning appears on admin/reports/status.

Proposed resolution

  • Only load Tippy.js when the library is enabled on admin/structure/webform/config/libraries.
  • If the library is not available, behave as if "Display element description as help text (tooltip)" is unchecked.
  • Put a warning next to "Display element description as help text (tooltip)" saying that it does not work without enabling Tippy.js.
CommentFileSizeAuthor
#5 3316667-4.patch5.69 KBjrockowitz

Comments

Liam Morland created an issue. See original summary.

anybody’s picture

Priority: Normal » Major

I can confirm this issue, setting priority to "Major" for legal (GDPR) reasons, as the library isn't only loaded on administrative pages for me, but globally!

The optional external library is unchecked at /admin/structure/webform/config/libraries still the library is loaded: <script src="https://unpkg.com/tippy.js@6.2.6/dist/tippy-bundle.umd.min.js"></script>

webform is the only module which contains the code snippet for this, as my grep just showed and led me here.

6.1.3 is the version used on the affected page.

anybody’s picture

Issue tags: +GDPR

The workaround for GDPR reasons is to follow the steps here to provide the library locally: https://www.drupal.org/docs/8/modules/webform/webform-frequently-asked-q...

Then its external loading script disappears.

jrockowitz’s picture

Version: 6.1.x-dev » 6.2.x-dev
jrockowitz’s picture

StatusFileSize
new5.69 KB
jrockowitz’s picture

Status: Active » Needs review

  • 46a8139 committed on 6.2.x
    Issue #3316667 by jrockowitz: Tippy.js is loaded via CDN even when...
jrockowitz’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.