Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
The 'copy install command' icons on the module modal have the wrong alt attribute text.
alt={Drupal.t('Copy the install command')}
The browser interprets this as:
Proposed resolution
Make the code be properly evaluated inside the template literal string (ActionButton.svelte).
Remaining tasks
- ✅ File an issue about this project
- ✅ Manual Testing
- ☐ Code Review
- ☐ Accessibility Review
- ❌ Automated tests needed/written?
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | Screenshot 2022-12-07 at 2.27.25 PM.png | 564.84 KB | narendrar |
| #3 | after-changes.png | 11.79 KB | mpaulo |
| inspect.png | 13.78 KB | mpaulo |
Issue fork project_browser-3314520
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
mpauloComment #4
ramonvasconcelos commentedI'll review it.
Comment #5
ramonvasconcelos commentedThe alt attribute is now correct after the changes from the MR.
+1
Comment #7
narendrarI can confirm that icon alt is rendering properly now. Moving to RTBC.
Comment #9
bnjmnmThis could benefit from a bit of test coverage, can probably be added to an existing test.
However, if the DrupalCI instance does not support
navigator.clipboard(unsure if it is https), then it's probably impractical to add such coverage and we can just explain that in this issue.Comment #10
narendrarAbove test passes on local. See
on localhost
http://localhost/project_browser/webIt might means that DrupalCI instance does not support navigator.clipboard.
Comment #11
bnjmnmI snuck in one bit of logic in the past two commits to get the test working. The first attempt had the right solution, but wrong place. It was necessary to commit and push that change myself as I wasn't sure it would work on DrupalCI. It's probably not appropriate for me to commit, but I was prepared to commit once the test worked, and my small addition got it to work.
Comment #12
bnjmnmComment #15
bnjmnmIt's been over a month since my one little change to the test and that's long enough to objectively look at it and give it a passing review along with the entire rest of the MR I approved last night. So welcome to the codebase 3314520