Problem/Motivation

The initialization script relies on jQuery. There is no need for it.
The initialization script fails to initialize multiple sliders

Proposed resolution

  • Change the initialization script and remove jQuery dependency to be in line with Drupal's deprecation of jQuery
  • Remove dependency on jQuery.once and use core/once
  • Fix the initialization of multiple sliders
CommentFileSizeAuthor
#4 3313870-remove-jquery-dependency.patch1.23 KBbohemier
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bohemier created an issue. See original summary.

bohemier’s picture

bohemier CreditAttribution: bohemier commented
Title: Cannot initialize multiple sliders, remove jquery dependency » Remove jquery dependency, fix for multiple sliders
bohemier’s picture

bohemier CreditAttribution: bohemier commented
Issue summary: View changes
bohemier’s picture

bohemier CreditAttribution: bohemier as a volunteer commented
Status: Active » Needs review
FileSize
3313870-remove-jquery-dependency.patch1.23 KB

Attaching patch

ipwa’s picture

ipwa CreditAttribution: ipwa at manifesto commented
Status: Needs review » Reviewed & tested by the community

Patch works well thank you so much @bohemier.

This fixes the issue when adding multiple sliders with view for example.

We still have the issue when using multiple fields with the field formatter. Will open a new ticket for this, its not really related to what this patch and issue is addressing.

  • ipwa committed 32356b3 on 1.0.x 
    Issue #3313870 by bohemier, ipwa: Remove jquery dependency, fix for...
ipwa’s picture

ipwa CreditAttribution: ipwa at manifesto commented

Committed, thanks for your contribution :D

ipwa’s picture

ipwa CreditAttribution: ipwa at manifesto commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.