Problem/Motivation

Custom made Image Effects based on the FocalPointEffectBase class are not displayed in the preview page.

Steps to reproduce

  1. Create custom ImageEffect that extends FocalPointScaleAndCropImageEffect.
  2. Create image style with new effect.
  3. Create media image and look for the image style in the preview page (nowhere to be found)

Proposed resolution

Fix todo in code base.

Remaining tasks

  1. Create patch
  2. Review patch

User interface changes

None

API changes

Extra parameter in Preview Page Controller

Data model changes

None

CommentFileSizeAuthor
#6 3311912-6.patch2.84 KBdinazaur
#2 3311912-2.patch2.78 KBtessa bakker

Issue fork focal_point-3311912

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Tess Bakker created an issue. See original summary.

tessa bakker’s picture

tessa bakker
she/they
Primary language Dutch
commented
Status: Active » Needs review
StatusFileSize
new 3311912-2.patch2.78 KB
rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented

Changes looks good to me.

spadxiii’s picture

spadxiii commented
Status: Needs review » Reviewed & tested by the community

Looks good and still applies to 2.x :)
We've been using this for almost a year in production now

martijn de wit’s picture

martijn de wit
Primary language Dutch
Location 🇳🇱 The Netherlands
commented
Assigned: tessa bakker » Unassigned
dinazaur’s picture

dinazaur commented
Priority: Normal » Major
StatusFileSize
new 3311912-6.patch2.84 KB

Re-roll for 2.1.
Since #2997675 was merged but no one updated effects array, I changed the status to Major because users can't see a preview of the plugin (focal_point_crop_by_width) that is provided by this module.

tessa bakker’s picture

tessa bakker
she/they
Primary language Dutch
commented
Version: 8.x-1.x-dev » 2.x-dev

Rajeshreeputra opened merge request !33

rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented

Will merge and release this weekend. Thanks for working on this!!

  • Rajeshreeputra committed 59891c32 on 2.x 
    Issue #3311912 by Rajeshreeputra, Tess Bakker, dinazaur, SpadXIII:...
rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented
Status: Reviewed & tested by the community » Fixed

Merged, release to follow shortly!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.