Problem/Motivation

https://www.drupal.org/pift-ci-job/2482757, one test fails because of the classy dependency (replace with starterkit_theme), the other one is weirder, some serialization problem?

My money is on #2531564: Fix leaky and brittle container serialization solution

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork block_field-3311760

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Berdir created an issue. See original summary.

ramonvasconcelos’s picture

ramonvasconcelos CreditAttribution: ramonvasconcelos at CI&T commented
Assigned: Unassigned » ramonvasconcelos

I'll see if i can fix it.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented

I had a quick look at the serialize test. Instead of mocking the thing, we should just use the container, I tested this change (twice)

-    // Prophesize translations to force service properties.
-    $translation = $this->prophesize(TranslationInterface::class);
-    $translation->willImplement(\Serializable::class);
-    $translation->serialize()->willThrow(\Exception::class);
-    $translation_service = $translation->reveal();
-    $translation_service->_serviceId = 'string_translation';
-    $plugin->setStringTranslation($translation_service);
+    $plugin->setStringTranslation(\Drupal::service('string_translation'));

and it works, tests are green again.

ramonvasconcelos opened merge request !8

ramonvasconcelos’s picture

ramonvasconcelos CreditAttribution: ramonvasconcelos at CI&T commented

I applied the changes you mentioned. Seems like there are other tests failing on 9.5. I'll take another look.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented

I picked a wrong PHP version there, although I did expect core to still be compatible with PHP 7.3, but apparently that's not the case, will double check. But that's nothing you need to look into.

ramonvasconcelos’s picture

ramonvasconcelos CreditAttribution: ramonvasconcelos at CI&T commented
Assigned: ramonvasconcelos » Unassigned
Status: Active » Needs review

Understood, thanks.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Fixed

Confirmed, Drupal 9.5 does indeed require PHP 7.4. Merged.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.