Drupal 10 compatibility issues

I have uploaded the patch. please review

Attached patch. Needs review.

Tested this module on Drupal 10.0.x and php 8.1 & following are my observations

- The patch #5 applies cleanly
- Was able to install 'Select2', 'Select2 Publish' and 'Select2 Facets' modules
- For node article tags taxonomy reference field used Select2 widget with default options
- Node add page the taxonomy reference field doesn't render correctly and there is a js error in the console
- Upgrade status also mentions a couple of issues which need to be fixed
- modules/select2_facets/js/select2-widget.js makes use of .once

$('.js-facets-select2.js-facets-widget')
  .once('js-facets-select2-widget-on-selection-change')
  .each(function () {

+++ b/js/select2.js
@@ -7,7 +7,7 @@
     attach: function (context) {
-      $('.select2-widget', context).once('select2-init').each(function () {
+      once('select2-init', '.select2-widget', context).forEach(function () {
         var config = $(this).data('select2-config');

this is not correctly converted. forEach works different and an argument needs to be passed in.

The easier, minimal fix is to pass once() to a jquery object like this: $(once()).each(... then the rest can remain unchanged.

Adding a patch to fix the above issues

Hi, @ameymudras, Verified and tested given patch #9. and checked in upgrade status. This is giving errors.

@DishaKatariya What errors? Can you post into a comment please?

Moving back to needs work based on #10.

It is compatible in upgrade status but giving warning errors now.

I have prepared a PR on github for D10 compatibility. Would be nice to get some reviews

https://github.com/thunder/select2/pull/121

Working during porting day.

@chr.fritsch Thanks for the changes. The expected workflow is to either update the patch from #9 and attach it here or create an MR (GitLab) and use that. Would you be able to do one of these approaches so it's easier for the community to review and test with existing tools like DrupalPod? Thanks.

Hi @Kristen Pol: The development of the select2 module has always been on github. I am trying to move it to d.o. in #3271610: Move testing to d.do to make it easier for the community, but some tests are failing on d.o. that are not failing locally or on github. So, until #3271610: Move testing to d.do is not fixed, the development will stay on github.

Oh! My mistake then… I didn't realize… thanks for the info.

I was able to invest some time and was able to finally move the select2 tests to drupal.org. Thanks to gitlab CI. Yay 🥳

So this issue has now a gitlab MR and is successfully tested by gitlab ci :)

Great 👍 Let us know how we can help 🙂

lgtm

Yay! Since you committed this, moving this back to Active for now so no one works on this but the bot can add patches. Feel free to marked fixed though :)

Community folks, see the compatible release here: https://www.drupal.org/project/select2/releases/8.x-1.x-dev

Oh! This isn't a bot issue 😂

@chr.fritsch Can this issue be moved to fixed or is there more to do?

Adding a FYI: If you're having issues with Select2 and PHP 8.1 try to download the latest develop version of the library (https://github.com/select2/select2) and replace it with the 2020 release.