Problem/Motivation

When searching for a block after clicking "Add block" while having a large number of blocks available, you will see empty spaces between block names.

Steps to reproduce

Given that I have varbase layout builder installed
When I click add block and try to search for a block
Then I'll see empty spaces between blocks that match the search

Proposed resolution

Remove padding from (li) elements and add margin instead, so that when (a) element inside it is hidden it won't be taking any additional space.

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ✅ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ✅ Release Varbase 9.0.9, varbase_layout_builder-10.0.20

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

  • Removed empty space between blocks' names

Before the fix

Before the fix - having empty space between block's names

After the fix

After the fix - Removed empty space between block's names

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Issue #3307036 by RedwanJamous: Fixed empty space between blocks' names when using search in blocks dialog

Comments

RedwanJamous created an issue. See original summary.

redwan jamous’s picture

Status: Active » Needs review
StatusFileSize
new1020 bytes
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

rajab natshah’s picture

Assigned: redwan jamous » Unassigned
rajab natshah’s picture

Issue summary: View changes

  • Rajab Natshah committed 44c3428 on 10.0.x
    Issue #3307036 by RedwanJamous: Fix empty space between blocks' names...

  • Rajab Natshah committed 0aa40a7 on 10.1.x
    Issue #3307036 by RedwanJamous: Fix empty space between blocks' names...
rajab natshah’s picture

rajab natshah’s picture

Assigned: Unassigned » mohammed j. razem
rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
rajab natshah’s picture

Issue summary: View changes
Status: Needs review » Fixed
rajab natshah’s picture

Issue summary: View changes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

rajab natshah’s picture

Issue summary: View changes

✅ Released Varbase 9.0.9