Problem/Motivation

In the administration menu there is no menu-link to Domain redirects.

Steps to reproduce

Proposed resolution

Let's add it.

image

Remaining tasks

Create en review patch

User interface changes

Link it available in menu

API changes

Data model changes

CommentFileSizeAuthor
#7 Screen Shot 2023-08-20 at 5.06.18 PM.png114.81 KBkristen pol
#7 Screen Shot 2023-08-20 at 5.01.52 PM.png102.96 KBkristen pol
#2 3306855-02--add-admin-menu-link-to-domain-redirect-configuration-page.patch467 bytesndf
Screenshot 2022-08-30 at 14.59.56.png10.34 KBndf

Comments

ndf created an issue. See original summary.

ndf’s picture

ndf commented
Status: Active » Needs review
StatusFileSize
new 3306855-02--add-admin-menu-link-to-domain-redirect-configuration-page.patch467 bytes
ndf’s picture

ndf commented

I followed the same naming and weights used in redirect_domain.links.task.yml and redirect.links.menu.yml

dimiter’s picture

dimiter commented
Status: Needs review » Reviewed & tested by the community

Reviewed and tested, works exactly as intended! As such I've changed the status to RTBC.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Assigned: Unassigned » kristen pol

Assigning to myself as I'm triaging all RTBC issues.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented

When reviewing this, I created this minor issue:

#3382165: Rename Settings to Redirect settings

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
StatusFileSize
new Screen Shot 2023-08-20 at 5.01.52 PM.png102.96 KB
new Screen Shot 2023-08-20 at 5.06.18 PM.png114.81 KB

I tested with the weight removed as I don't think we need that (then it'll do alphabetical). I'll get this merged soon.

Before

After

  • Kristen Pol committed 85657e06 on 8.x-1.x authored by ndf 
    Issue #3306855 by ndf, Kristen Pol, Dimiter: Admin menu-link Domain...
kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Assigned: kristen pol » Unassigned
Status: Reviewed & tested by the community » Fixed

Thanks, everyone. This has been merged (without the weight) and will be in the next release.

ndf’s picture

ndf commented

Thanks Kristen!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.