Themes in profiles directory not discovered during install

Hi. We have experienced the same problem which is not a themes problem but a bug in the install system. Themes are not recognized during installation because when they are determined first the profile global variable is unset. The theme info is cached in a static variable in _system_theme_data so it never recovers during the whole process. The attached patch solved the problem in our case, though it's far from elegant.

There is no patch.

Here it is. Sorry.

There is a patch now.

This core bug still exists in all versions of Drupal 6.

Note that it seems this is a regression from 5.x, as I can enable a theme in my install profile here, if it's profiles/hostmaster/themes/eldir. See #458362: enable the eldir theme on install if available for how I did it.

I have redone the patch to remove code duplication and clarify the comments, it now needs testing. Note that this is now irrelevant in Drupal 7, as install.php is being rewritten (see #525594: Installation should consist of 2 phases instead of one and #524728: Refactor install.php to allow Drupal to be installed from the command line)

Here is a fix to anarcat's patch.

marking this as critical (at least is critical for Aegir and also for all install profiles that provide a theme).

This issue also effects the new d.o. install profile packager. We ran into this issue with the Uberdrupal profile. I applied the patch, and it works as expected.

We just ran into this while testing http://drupal.org/node/657834. The new distribution packaging system puts themes under the profile directory, since that's supposed to be the best practice. However, install profiles like UberDrupal are trying to set a theme and that fails given this bug.

Note: this is a hacky way to fix this problem, but unless we introduce a $reset parameter to _system_theme_info(), I don't know how else we're supposed to clear the static $theme_info in there. :( This isn't a problem in D7 since we have drupal_static() there. Marking this a 6.15 blocker, since this really has the potential to cause a lot of problems once more packaged distros get off the ground.

Bugs are first fixed in the latest / development version of Drupal to avoid regressions in later versions. Also, the code comments can use some typo fixing, dots at end of sentence and empty line removal.

I've tested d7, and it is not effected by this issue. See comment #14

Note that a similar issue does exist in Drupal 7, and was reported at #585012: Setting a default theme in install profile causes WHACK errors -- looks like that probably should have been a duplicate of this one. However, it also seems the bug is much more serious in Drupal 6, so not sure what the proper thing to do is here? (We still want to make sure this gets fixed in Drupal 7 also.)

Anyway, it turns out that the latest (D7) patch at the other issue takes a similar approach as this one. The patch here looks correct to me for Drupal 6, but I haven't tested it.

Subscribing. :-)

I just tested patch #17 with uberdrupal 6.x-1.0-alpha5 -- worked like a charm. The patch is small and clean. It solves a critical bug that's breaking an important feature on drupal.org. D7 has a different installer and the API is different, and there's already a patch at #585012-9: Setting a default theme in install profile causes WHACK errors. It uses a similar approach, but since core changed, the patch is different. Please, please, please (did I mention please?) let's fix this now in D6. Let us not make multiple release of D6 core with this known bug while we await D7 converging on a solution. Please? ;)

Thanks!
-Derek

I'm with dww -- this bug is blocking my ability to create one of the distros that I have on my plate. Getting this into the next Drupal release would be a big boon. I don't think it matters if D7 and D6 handle this one differently, it's the install process. You run it once and never see it again, all we care about in both cases is that it installs correctly.

We can confirm that dww's patch seems to work for Innovation News as well. With the patch applied, we are able to enable our custom, packaged theme without using any workarounds.

subscribe

in my install profiles i always set the profile in the settings.php file

these are the related issues

#585012: Setting a default theme in install profile causes WHACK errors
#545452: Store install profile in the generated settings.php file

Committed to Drupal 6.

Yay, thanks!!! ;)