Problem/Motivation

Composer is fixed to docroot folder and should use web-root such as core composer to let use this project into custom folder.

Steps to reproduce

Having issues with custom composer build with Varbase profile conflicting with changes over Varbase Project template
When changed in projects, composer will face issues on builds and updates

Proposed resolution

1. Double-check what Drupal Recommended Project
https://github.com/drupal/recommended-project/blob/9.4.5/composer.json#L43
2. Check Acquia Drupal Recommended Project
https://github.com/acquia/drupal-recommended-project/blob/1.11.19/compos...

3. Use the right web-root in both Varbase profile and Varbase Project template

    "drupal-scaffold": {
      "allowed-packages": [
        "drupal/core",
        "vardot/varbase"
      ],
      "gitignore": true,
      "locations": {
        "web-root": "./docroot"
      },
      "file-mapping": {
        "[web-root]/sites/default/default.services.yml": {
          "mode": "replace",
          "overwrite": false,
          "path": "docroot/core/assets/scaffold/files/default.services.yml"
        },
        "[web-root]/sites/default/default.settings.php": {
          "mode": "replace",
          "overwrite": false,
          "path": "docroot/core/assets/scaffold/files/default.settings.php"
        },
        "[web-root]/robots.txt": {
          "append": "docroot/profiles/varbase/src/assets/varbase-robots-additions.txt"
        }
      }
    },

Projects could change "web-root": "docroot/" and docroot to web using change or a clone of the Varbase Project Template
Have drupal-scaffold locations web-root for Varbase Project template as docroot to fix composer web-root folder in projects #146

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ✅ Release varbase-9.0.8

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Issue #3301451 by vacho: Have drupal-scaffold locations web-root for Varbase as docroot to fix composer web-root folder in projects

Issue fork varbase-3301451

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

vacho created an issue. See original summary.

vacho’s picture

Version: 9.1.x-dev » 9.0.x-dev

rajab natshah’s picture

Title: Composer is fixed to docroot folder Primary tabs View(active tab) » Have drupal-scaffold locations web-root for Varbase as docroot to fix composer web-root folder in projects
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Status: Active » Needs review
Issue tags: +varbase-9.0.8
rajab natshah’s picture

Issue summary: View changes

  • Rajab Natshah committed 7c94fef on 10.0.x
    Issue #3301451: Have drupal-scaffold locations web-root for Varbase as...

  • Rajab Natshah committed 3e5e475 on 10.0.x
    Issue #3301451: Have drupal-scaffold locations web-root for Varbase as...

  • Rajab Natshah committed 7377292 on 9.0.x
    Issue #3301451: Have drupal-scaffold locations web-root for Varbase as...

  • Rajab Natshah committed 5caaede on 9.0.x
    Issue #3301451: Have drupal-scaffold locations web-root for Varbase as...
rajab natshah’s picture

Assigned: Unassigned » mohammed j. razem
Issue summary: View changes

Restricting the use of changing files only to Drupal core and Varbase Profile

    "drupal-scaffold": {
      "allowed-packages": [
        "drupal/core",
        "vardot/varbase"
      ],

Not to let any package or module use the Drupal Scaffold to do any changes to Drupal files.
If a package was selected to do any change to files it should be listed in the Allowed Packages list.

rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned

  • Rajab Natshah committed f2ef95e on 9.0.x
    Issue #3301451: Have drupal-scaffold locations web-root for Varbase as...
rajab natshah’s picture

Issue summary: View changes

  • Rajab Natshah committed 3eba48c on 10.0.x
    Issue #3301451: Have drupal-scaffold locations web-root for Varbase as...
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Status: Needs review » Fixed
rajab natshah’s picture

Issue summary: View changes

✅ Released varbase-9.0.8

rajab natshah’s picture

Status: Fixed » Closed (fixed)
rajab natshah’s picture

Issue summary: View changes