Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

Status: Active » Needs review
StatusFileSize
new1.03 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module this patch makes this module compatible with Drupal 10! 🎉
This patch updates the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #139

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.24
  2. palantirnet/drupal-rector: 0.13.0
Bushra Shaikh’s picture

Assigned: Unassigned » Bushra Shaikh
Issue summary: View changes
Bushra Shaikh’s picture

Assigned: Bushra Shaikh » Unassigned
StatusFileSize
new65.2 KB
new42.46 KB

Verified and tested patch#2 on drupal 10.0.x and 10.1.x version. Patch applied successfully and looks good to me.

Testing Steps:

  1. Install drupal 10.0.x and 10.1.x version.
  2. Clone "Worldmap".
  3. And you will be unable to enable the module.
  4. Now apply the patch.
  5. Clear cache and refresh the page.
  6. Install the module

Testing result:

World Map was installed successfully and is compatible with drupal 10.

Can be move to RTBC+1

vinmayiswamy’s picture

StatusFileSize
new48.69 KB
new262.45 KB

Reviewed the patch:
1 Downloaded and installed the "Project Update Bot" patch - #2.
2. Examined the module based on Upgrade Status
3. No issues were discovered in the Upgrade Status report.
4. Tested the functionality by placing the block in content region after applying the patch.
Attached the report

vinmayiswamy’s picture

Issue tags: +Drupal 10 porting day
vinmayiswamy’s picture

kristen pol’s picture

Thank you for participating in porting day!

@Bushra Shaikh It looks like you installed the module on Drupal 10 but didn't test it. Installation is not sufficient for checking compatible; it must be tested for functionality.

@VinmayiSwamy Thank you for testing the module functionality. It's unclear why you added a patch as it seems the same as the bot patch. You shouldn't include a patch unless you updated it and in that case should include an interdiff and explanation why it was updated.

For both of you, in the future, please do not include screenshots of the module showing it is disabled/enabled or that the upgrade status report shows it is compatible as that is not helpful. You can just explain that it can or cannot be enabled or that the report shows it's compatible.

But, if you test the module on Drupal 10 and there are useful screenshots that show it working, that is okay to include.

Thanks!

vinmayiswamy’s picture

Hai @Kristen Pol,

The patch included with my review accidentally. I tried to remove it but there is no such option available to remove, so I tried to hide it. It is the same patch as bot that I tested.

Thank you so much for your feedback. Your feedback and suggestions are valuable for the first time participants like me. I'll keep it in mind for my next contributions.

Thanks!

project update bot’s picture

kristen pol’s picture

Issue summary: View changes

Working during porting day.

@VinmayiSwamy Thanks for the details. I'm unclear whether you tested the patch on Drupal 9 or 10 in #5. It needs to be tested on Drupal 10 before being marked RTBC. Do you remember?

grienauer’s picture

Assigned: Unassigned » granik
gaurav-mathur’s picture

Assigned: granik » Unassigned

There is no update for a long time, so I will review it.

gaurav-mathur’s picture

StatusFileSize
new6.95 KB
new9.13 KB

Verified and tested patch #2.
Patch applied successfully.

Testing steps :-

1. Go to Drupal 10.1.x-dev.
2. Check module "Worldmap" is compatible.
3. Clone the module on drupal 10.1.x-dev.
4. Apply the patch.
5. Clear cache and goto extend -> search module name -> Worldmap -> install

Result :- World Map was installed successfully and is compatible with drupal 10.1.x-dev.
Adding screenshots for reference.

criz’s picture

Status: Needs review » Reviewed & tested by the community

  • granik committed db6eea09 on 1.0.x
    Issue #3299520 by Project Update Bot, VinmayiSwamy, gaurav-mathur,...
granik’s picture

Assigned: Unassigned » granik
Status: Reviewed & tested by the community » Fixed

Thanks everyone, committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.