Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

CommentFileSizeAuthor
#21 3297446-21.patch4.71 KBmarthinal
#17 iu_paragraphs-3297446-17.patch741 bytesmarthinal
#11 Screen Shot 2023-05-04 at 12.47.23 PM.png147.01 KBjwilson3
#6 iu_paragraphs-3297446-6.patch4.37 KBjwilson3
#5 iu_paragraphs-3297446-5.patch4.37 KBjwilson3
#5 interdiff-4-5.diff685 bytesjwilson3
#4 iu_paragraphs-3297446-4.patch4.27 KBjwilson3
#2 iu_paragraphs.2.0.x-dev.rector.patch3.67 KBproject update bot

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

project update bot commented
Status: Active » Needs review
StatusFileSize
new iu_paragraphs.2.0.x-dev.rector.patch3.67 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.13.0, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #139

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.24
  2. palantirnet/drupal-rector: 0.13.0
project update bot’s picture

project update bot commented
Issue summary: View changes

Updating bot issue summary.See #3313904: Update project bot templates for RTBC status support and human interaction tips

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented
Issue summary: View changes
StatusFileSize
new iu_paragraphs-3297446-4.patch4.27 KB

The automated patches created by the bot generates lots of duplicate code and long lines, which I've fixed in the following patch.

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented
StatusFileSize
new interdiff-4-5.diff685 bytes
new iu_paragraphs-3297446-5.patch4.37 KB

Whoops. transformRelative() should have been generateString()
See https://www.drupal.org/node/2940031

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented
StatusFileSize
new iu_paragraphs-3297446-6.patch4.37 KB

Reupload after configuring tests against version 2.0.x

Status: Needs review » Needs work

The last submitted patch, 6: iu_paragraphs-3297446-6.patch, failed testing. View results

  • jwilson3 committed 4afd04a3 on 2.0.x 
    Issue #3297446 by jwilson3: Drupal 10 compatibility fixes
jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented
Status: Needs work » Active

Setting back to active. Test failed because there are no tests, but we're using the test runner to just ensure the patches apply.

  • jwilson3 committed 36436ded on 2.1.x 
    Issue #3297446 by jwilson3, Project Update Bot: Add Drupal 10...
jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented
StatusFileSize
new Screen Shot 2023-05-04 at 12.47.23 PM.png147.01 KB

Running upgrade status is still reporting issues, though I'm not entirely certain why.

  • jwilson3 committed 26cb12a1 on 2.1.x 
    Issue #3297446 by jwilson3: [drupal-check] ensure variable is defined...

  • jwilson3 committed 00020ddc on 2.1.x 
    Issue #3297446 by jwilson3: [drupal-check] fix function return statement...
jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented

I decided to install and test with palantirnet/drupal-rector and mglaman/drupal-check manually.

Drupal-check found 5 errors, but they don't seem to be strictly required for Drupal 10 compatibility.

❯ ddev composer require mglaman/drupal-check --dev -W
❯ ./vendor/bin/drupal-check --drupal-root web --memory-limit 2048M --php8 web/modules/contrib/iu_paragraphs
 3/3 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ -----------------------------------------------------------------
  Line   iu_paragraphs.module
 ------ -----------------------------------------------------------------
  344    Function _iu_paragraphs_get_file_uri() should return string but
         return statement is missing.
  566    Variable $details might not be defined.
 ------ -----------------------------------------------------------------

 ------ -----------------------------------------
  Line   src/Plugin/Condition/EntityType.php
 ------ -----------------------------------------
  77     Variable $options might not be defined.
  129    Variable $labels might not be defined.
  144    Variable $labels might not be defined.
 ------ -----------------------------------------

 [ERROR] Found 5 errors

Thanks for using drupal-check!

Consider sponsoring the development of the maintainers which make drupal-check possible:

- phpstan (ondrejmirtes): https://github.com/sponsors/ondrejmirtes
- phpstan-deprecation-rules (ondrejmirtes)): https://github.com/sponsors/ondrejmirtes
- phpstan-drupal (mglaman)): https://github.com/sponsors/mglaman
- drupal-check (mglaman)): https://github.com/sponsors/mglaman

Rector found no issues that could be automatically fixed:

ddev composer require palantirnet/drupal-rector --dev -W
cp vendor/palantirnet/drupal-rector/rector.php .
❯ ./vendor/bin/rector process web/modules/contrib/iu_paragraphs
 312/312 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%


 [OK] Rector is done!

These have been fixed by the previous commits.

  • jwilson3 committed c73d8bdf on 2.1.x 
    Issue #3297446 by jwilson3: Add Drupal 10 compatibility to webform...
jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented

These fixes are available and current as of release 2.1.8

marthinal’s picture

marthinal commented
StatusFileSize
new iu_paragraphs-3297446-17.patch741 bytes

I found one more problem

  • jwilson3 committed 776e7e78 on 2.1.x 
    Issue #3297446 by marthinal, jwilson3: Twig 2.10 deprecates use of if in...
jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented

Thanks!

  • jwilson3 committed fc7328f3 on 2.1.x 
    Issue #3297446 by marthinal, jwilson3: Twig 2.10 deprecates use of if in...
marthinal’s picture

marthinal commented
StatusFileSize
new 3297446-21.patch4.71 KB

Hey I found some regressions

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented
Status: Active » Needs review

  • jwilson3 committed c927ef00 on 2.1.x 
    Issue #3297446 by marthinal, jwilson3: Twig 2.10 deprecates use of if in...
jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented
Status: Needs review » Active

Thanks @marthinal! Merged and tagged fix with release 2.1.11 .

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented
Status: Active » Fixed

Issue queue cleanup. Drupal 11 is now out.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.