Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Periodically patches will be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted simply close this issue (any status besides Active, Needs review or Needs work) or remove the "ProjectUpdateBotD10" tag from the issue.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review or Needs work) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but don't want new automated patches simply leave this issue open but remove the "ProjectUpdateBotD10" tag from the issue.

    You can use Drupal Rector yourself to make these patches.

    If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review or Needs work) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it may be useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the patch in the comment by Project Update Bot.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Infrastructure project issue queue using the component “Bot: Drupal Rector”.

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

Status: Active » Needs review
StatusFileSize
new356 bytes

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module this patch makes this module compatible with Drupal 10! 🎉
This patch updates the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #139

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.24
  2. palantirnet/drupal-rector: 0.13.0
omkar-pd’s picture

This module is Compatible as per Upgrade status I also tested manually on the D10 instance and it's working fine.

omkar-pd’s picture

This can be moved to RTBC.

kristen pol’s picture

Status: Needs review » Reviewed & tested by the community

@omkar-pd Thank you for participating in porting day, checking the patch on Drupal 9, and testing the patch on Drupal 10!

Moving to RTBC.

I see the last commit was about 2 weeks ago by @larowlan so maybe this will get in soon :)

mradcliffe’s picture

Status: Reviewed & tested by the community » Needs review

I'm changing this back to "Needs review" so that further patches can be included per the issue summary. We can let the maintainer of the module decide whether they would prefer to close the issue to further patches.

If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review or Needs work) and no more automated patches will be posted here

kristen pol’s picture

Thanks everyone for participating in porting day!

There isn't currently consensus on using RTBC on these bot issues so we'll be discussing that at the next #d10readiness meeting :)

kristen pol’s picture

Status: Needs review » Reviewed & tested by the community

Finally getting back to these. We did talk about marking these RTBC in a couple #d10readiness meetings and the consensus was to mark them RTBC as long as the module/theme was actually tested on Drupal 10 and was working as expected and the code changes look okay.

It appears that the module was tested on Drupal 10 per #3 so moving to RTBC.

@omkar-pd In the future, please do not include screenshots of the module showing it is disabled/enabled or that the upgrade status report shows it is compatible as that is not helpful. You can just explain that it can or cannot be enabled or that the report shows it's compatible. But, if you test the module on Drupal 10 and there are useful screenshots that show it working, that is okay to include.

omkar-pd’s picture

Sure, @Kristen Pol, I'll Keep this in mind. Thank you

  • larowlan committed 08060a2 on 8.x-1.x
    Issue #3296928 by Project Update Bot: Automated Drupal 10 compatibility...
larowlan’s picture

Status: Reviewed & tested by the community » Fixed
kristen pol’s picture

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.