Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Periodically patches will be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted simply close this issue (any status besides Active, Needs review or Needs work) or remove the "ProjectUpdateBotD10" tag from the issue.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review or Needs work) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but don't want new automated patches simply leave this issue open but remove the "ProjectUpdateBotD10" tag from the issue.

    You can use Drupal Rector yourself to make these patches.

    If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review or Needs work) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it may be useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the patch in the comment by Project Update Bot.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Infrastructure project issue queue using the component “Bot: Drupal Rector”.

CommentFileSizeAuthor
#7 ckeditor_uploadimage-3296773-7.patch5.47 KBmarc.groth
#6 ckeditor_uploadimage-3296782-6.patch5.82 KBmarc.groth
#2 ckeditor_uploadimage.2.x-dev.rector.patch3.2 KBproject update bot

Issue fork ckeditor_uploadimage-3296782

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

project update bot commented
Status: Active » Needs review
StatusFileSize
new ckeditor_uploadimage.2.x-dev.rector.patch3.2 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.13.0, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #139

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.24
  2. palantirnet/drupal-rector: 0.13.0

earthday47 made their first commit to this issue’s fork.

earthday47 opened merge request !2

earthday47’s picture

earthday47
Location New York
commented
Issue summary: View changes

Created fork with the automated fixes, added core_version_requirement.

marc.groth’s picture

marc.groth commented
StatusFileSize
new ckeditor_uploadimage-3296782-6.patch5.82 KB

Thanks @earthday47. I was able to use your PR to create a patch which I applied to the module... Which makes it D10 compatible.

I have attached the patch in case it is useful for somebody.

marc.groth’s picture

marc.groth commented
StatusFileSize
new ckeditor_uploadimage-3296773-7.patch5.47 KB

I just noticed that a line break is added to the .info.yml file as part of this patch which actually breaks when Drupal metadata is added to the file (because the line break should not be there according to the original file). I have attached an updated patch that takes this into account.

The original .info.yml file will need to updated to include the line break if needed (which is suggested to keep it consistent with Drupal coding standards).

devil2005’s picture

devil2005 commented

Hi,

Is there any release of a stable version for D10 please ?
Apply #2 with success but #6 and #7 can't

thanks

amanire’s picture

amanire commented

The patch in #7 applied to 8.x-2.0 for me. Thank you!

caspervoogt’s picture

caspervoogt commented

#7 worked for me

socialnicheguru’s picture

socialnicheguru commented
Status: Needs review » Reviewed & tested by the community

Works for me too

vlad.dancer’s picture

vlad.dancer
Primary language Ukrainian
Location Kyiv
commented

Hey @devil2005 you can require d10 compatible module version in the next way:

composer remove drupal/ckeditor_uploadimage

Then edit composer.json:

{
      "type": "package",
      "package": {
        "name": "drupal/ckeditor_uploadimage",
        "type": "drupal-module",
        "version": "dev-2.x",
        "source": {
          "type": "git",
          "url": "https://git.drupalcode.org/issue/ckeditor_uploadimage-3296782.git",
          "reference": "f87155bc4d671a6763b93c49bd0bececcd37d763"
        }
      }
    },

And place the above right before:

{
      "type": "composer",
      "url": "https://packages.drupal.org/8"
    },
    {
      "type": "composer",
      "url": "https://asset-packagist.org"
    },

Then run composer require drupal/ckeditor_uploadimage:dev-2.x
The last step you might need to run two times.

p-neyens’s picture

p-neyens commented

After upgrading a D9 to D10 site i get the following warning

Undefined array key "max_size" when using the format ""

I created a new ticket for that