Problem/Motivation
Hello project maintainers,
This is an automated issue to help make this module compatible with Drupal 10.
To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects
Periodically patches will be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted simply close this issue (any status besides Active, Needs review or Needs work) or remove the "ProjectUpdateBotD10" tag from the issue.
The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.
Proposed resolution
You have a few options for how to use this issue:
- Accept automated patches until this issue is closed
If this issue is left open (status of Active, Needs review or Needs work) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.
As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.
- Leave open but stop new automated patches.
If you want to use this issue as a starting point to remove deprecated API uses but don't want new automated patches simply leave this issue open but remove the "ProjectUpdateBotD10" tag from the issue.
You can use Drupal Rector yourself to make these patches.
If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.
- Close it and don't use it
If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review or Needs work) and no more automated patches will be posted here.
If the issue is reopened, then new automated patches will be posted.
If you are using another issue(s) to work on Drupal 10 compatibility it may be useful to other contributors to add those issues as "Related issues" when closing this issue.
Remaining tasks
Using the patches
- Apply the patch in the comment by Project Update Bot.
- Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
Providing feedback
If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Infrastructure project issue queue using the component “Bot: Drupal Rector”.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | ckeditor_font.1.x-dev.rector.patch | 1.88 KB | project update bot |
Comments
Comment #2
project update bot commentedThis is an automated patch generated by Drupal Rector. Please see the issue summary for more details.
It is important that any automated tests available are run with this patch and that you manually test this patch.
Drupal 10 Compatibility
According to the Upgrade Status module this patch makes this module compatible with Drupal 10! 🎉
This patch updates the
info.ymlfile for Drupal 10 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.
Debug info
This patch was created using these packages:
Comment #4
akshaydalvi212 commentedHello,
Thanks for the auto-bot patch,
I will review the patch.
Comment #5
akshaydalvi212 commentedHello,
Before applying the patch, getting below errors for drupal 10 compatibilities:
After applying the patch, the module gets compatible with drupal 10 as per
the scan result of the upgrade-status module
The module gets installed on drupal 10
But while the configuration of the button on CKEditor getting following error
Need to update the patch and solve the problem with the non-existing service.
Hence shifting the status of issue to Needs work.
Thanks and regards,
Comment #6
omkar-pd commentedCan confirm the error.
Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException: You have requested a non-existent service "site.path". in Drupal\Component\DependencyInjection\Container->get() (line 156 of core/lib/Drupal/Component/DependencyInjection/Container.php).
Comment #7
omkar-pd commentedAdding this
$directories[] = \Drupal::getContainer()->getParameter('site.path') . "/libraries/";instead of$directories[] = \Drupal::service('site.path') . "/libraries/";will solve the error and work in both d9 and d10 as well.Comment #8
akshaydalvi212 commentedHello,
Thank you for the help @omkar-pd,
Providing the patch for solving the non-existing service error.
Shifting the issue status to Needs review.
Comment #9
omkar-pd commentedThe patch solves the issue. Module working fine. This module is fully compatible with d10 now.
Comment #10
WebbehThanks for the test and patch. I will commit and provide credits for this.
Comment #11
WebbehComment #13
WebbehFixed. Thanks.