Hello project maintainers,
This is an automated issue to help make this module compatible with Drupal 10.
To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects
Periodically patches will be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted simply close this issue (any status besides Active, Needs review or Needs work) or remove the "ProjectUpdateBotD10" tag from the issue.
The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.
You have a few options for how to use this issue:
If this issue is left open (status of Active, Needs review or Needs work) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.
As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.
If you want to use this issue as a starting point to remove deprecated API uses but don't want new automated patches simply leave this issue open but remove the "ProjectUpdateBotD10" tag from the issue.
You can use Drupal Rector yourself to make these patches.
If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.
If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review or Needs work) and no more automated patches will be posted here.
If the issue is reopened, then new automated patches will be posted.
If you are using another issue(s) to work on Drupal 10 compatibility it may be useful to other contributors to add those issues as "Related issues" when closing this issue.
Using the patches
If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Infrastructure project issue queue using the component “Bot: Drupal Rector”.
| Comment | File | Size | Author |
|---|
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
project update bot commentedThis is an automated patch generated by Drupal Rector. Please see the issue summary for more details.
It is important that any automated tests available are run with this patch and that you manually test this patch.
Drupal 10 Compatibility
According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.
Currently Drupal Rector, version 0.13.0, cannot fix all Drupal 10 compatibility problems.
This patch does not update the
info.ymlfile for Drupal 10 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.
Debug info
This patch was created using these packages:
Comment #3
amin.ankithi,
Thanks for the auto-bot patch,
I will review the patch.
Comment #4
rossb89 commentedI've created the Drupal 10 compatible patch manually, and used this as an opportunity to use DI in the AddToAnySettingsForm class properly (it was previously a mix of some DI calls and some manual
\Drupal::service()calls). We should be using DI instead of\Drupal::service()style calls when in an OO context.Patch attached.
Comment #5
amin.ankitHi,
Testing Steps:
1. Install the Add to Any module on drupal 9
2. Applied patch #4 and checked the upgrade status on drupal 9 (Note: 1 issue found) - attached screenshot.
3. Fixed issue and re-created patch #5 along with patch #4 changes.
4 Applied patch #5 and checked the upgrade status on drupal 9 (Note: 0 issues) - attached screenshot.
5. Install drupal 10
6. Install the Add to Any module on drupal 10
5. Enable the module (attached screenshot) (Note: 1 Issue found ) - attached screenshot
6. Fixed the twig template issue and re-created patch #5.
7. Applied patch #5
8. Screenshot after enabled module.
Please review #5.
Thanks,
Ankit Amin
Comment #6
amin.ankitComment #8
vladimirausThank you
Comment #11
alt.dev commentedThis module can't be added to the D10 project via the composer since the requirement inside of the composer.json file wasn't changed as a part of this task. I created the MR to resolve this issue and now this task needs to be reviewed.
Comment #13
vladimirausThanks for noticing and fixing it @alt.dev.
Merging. 🍻
Also hiding files as all committed to dev branch.
To test Drupal 10 run
I cannot do the release as mentioned in #3328336: Offering to maintain AddToAny Share Buttons.
Comment #14
mark_fullmerA new release by the maintainers who can do this would be much appreciated!
Comment #15
loopy1492 commentedDev version works for us on our sites. A new release would be great.
Comment #16
vladimirausI'm trying to reach maintainers but they are not replying. Details #3328336: Offering to maintain AddToAny Share Buttons.
Comment #17
vladimirausGot access! 🥳
Working on D10 release.
Comment #19
vladimirausAs requested by maintainers, 8.x branch should have 8 and 9 support.
Comment #20
mark_fullmerGlad to hear about you being a new maintainer, VladmirAus! Let us know if we can do anything to help with this release!
Comment #24
vladimiraus2.0.x is now ready with Drupal 10 support!
Thanks everyone! 🍻
Comment #25
loopy1492 commentedWhile the Upgrade Status module still thinks the old 1.x track is the "Drupal.org" version, installing ^2.0 locally does mark the module as Drupal 10 Ready locally, so I think we're good to go here. Thanks!