phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,yaml,feature,js,json,ts,tsx,feature,twig /admin_toolbar

FILE: /home/tempacc/Desktop/ddev/admin_toolbar/admin_toolbar_tools/admin_toolbar_tools.services.yml
---------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------
7 | ERROR | [x] Expected 1 newline at end of file; 0 found
---------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------

FILE: /home/tempacc/Desktop/ddev/admin_toolbar/admin_toolbar_tools/css/tools.css
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
47 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: /home/tempacc/Desktop/ddev/admin_toolbar/admin_toolbar_tools/src/Plugin/Derivative/ExtraLinks.php
--------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------
373 | ERROR | The array declaration extends to column 86 (the limit is 80). The array content should be split up over multiple lines
--------------------------------------------------------------------------------------------------------------------------------------

FILE: /home/tempacc/Desktop/ddev/admin_toolbar/admin_toolbar_tools/src/AdminToolbarToolsHelper.php
--------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
--------------------------------------------------------------------------------------------------
56 | ERROR | [x] Expected 3 space(s) before asterisk; 4 found
57 | ERROR | [x] Expected 3 space(s) before asterisk; 4 found
58 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3
59 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 5
60 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3
--------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------

FILE: /home/tempacc/Desktop/ddev/admin_toolbar/js/jquery.hoverIntent.js
-------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------
67 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
-------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------

FILE: /home/tempacc/Desktop/ddev/admin_toolbar/admin_toolbar_search/js/admin_toolbar_search.js
----------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
----------------------------------------------------------------------------------------------
13 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
38 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
45 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
60 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
65 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
----------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------

FILE: /home/tempacc/Desktop/ddev/admin_toolbar/tests/src/Functional/AdminToolbarAdminMenuTest.php
-------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------
5 | WARNING | [x] Unused use statement
6 | WARNING | [x] Unused use statement
-------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------

CommentFileSizeAuthor
#7 interdiff_2-7.txt1.63 KBmrinalini9
#7 fix-coding-standards-3295269-7.patch3.62 KBmrinalini9
#2 fix-coding-standards-3295269-2.patch5.1 KBishani patel

Comments

Ishani Patel created an issue. See original summary.

ishani patel’s picture

ishani patel commented
Assigned: ishani patel » Unassigned
Status: Active » Needs review
StatusFileSize
new fix-coding-standards-3295269-2.patch5.1 KB

Kindly review the patch.
Thanks.

atul_ghate’s picture

atul_ghate commented
Assigned: Unassigned » atul_ghate

Hi,
I will review this patch

Status: Needs review » Needs work

The last submitted patch, 2: fix-coding-standards-3295269-2.patch, failed testing. View results

atul_ghate’s picture

atul_ghate commented
Assigned: atul_ghate » Unassigned
Status: Needs work » Reviewed & tested by the community

All coding standard issues have been resolved by the above patch, moving its status to RTBC.

adriancid’s picture

adriancid
Primary language Spanish
Location Qc, Canada 🇨🇦
commented
Status: Reviewed & tested by the community » Needs work 
  1. +++ b/admin_toolbar_search/js/admin_toolbar_search.js
@@ -10,7 +10,7 @@
+    extraFetched: FALSE,

    This needs to remain as false is javascript 

  2. +++ b/admin_toolbar_search/js/admin_toolbar_search.js
@@ -35,14 +35,14 @@
+                $self.extraFetched = TRUE;

    Same here 

  3. +++ b/admin_toolbar_search/js/admin_toolbar_search.js
@@ -57,12 +57,12 @@
+            return FALSE;

    Same here 

  4. +++ b/admin_toolbar_search/js/admin_toolbar_search.js
@@ -57,12 +57,12 @@
+              return FALSE;

    Same here 

  5. +++ b/js/jquery.hoverIntent.js
@@ -64,7 +64,7 @@
+      s.isActive = TRUE;

    Same here

mrinalini9’s picture

mrinalini9 commented
Status: Needs work » Needs review
StatusFileSize
new fix-coding-standards-3295269-7.patch3.62 KB
new interdiff_2-7.txt1.63 KB

Updated patch #2 by addressing #6, please review it.

Shubham Sharma 77’s picture

Shubham Sharma 77 commented
Status: Needs review » Reviewed & tested by the community

Coding standard issues have been resolved. Move this ticket to RTBC.

adriancid’s picture

adriancid
Primary language Spanish
Location Qc, Canada 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Thanks

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.