Logging in causes the error,

Deprecated function: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in Drupal\Component\Utility\UrlHelper::isExternal() (line 216 of core/lib/Drupal/Component/Utility/UrlHelper.php).

CommentFileSizeAuthor
#4 3292255-4.patch784 bytesdarvanen
#2 3292255.patch746 bytesszymon-gorecki
login_destination.patch643 bytesSteven McCoy

Comments

Steven McCoy created an issue. See original summary.

szymon-gorecki’s picture

szymon-gorecki commented
StatusFileSize
new 3292255.patch746 bytes

The default value can be set as a parameter of the get method

sayco’s picture

sayco commented
Status: Active » Reviewed & tested by the community

The proposed patch #2 seems to be a better proposal (as the get methods provides the default value argument).
I've test the patch and works as expected!

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 3292255-4.patch784 bytes

Why invoke UrlHelper on an empty string?

I propose a different, simpler approach. Patch attached.

kalpaitch’s picture

kalpaitch commented

#4 Actually my apologies that looks like the best approach and does fit the logic :)

kalpaitch’s picture

kalpaitch commented
kalpaitch’s picture

kalpaitch commented
Status: Needs review » Reviewed & tested by the community

Looks good on review.

  • rsvelko committed 3534a34 on 8.x-2.x 
    Issue #3292255 by Steven McCoy, szymon-gorecki, darvanen, kalpaitch: Can...
rsvelko’s picture

rsvelko commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.