Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
Discovered whilst working on #3227033: Remove Quick Edit from core
core/modules/ckeditor5/tests/src/Functional/CKEditor5QuickEditLibraryTest.php tests the integration of CKEditor5 with Quick Edit.
Since Quick Edit is on it's way out of core (and live long and prosper in Contrib) we need to move this file and namespace to the land of quickedit
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | 3291018-5-suggestions-do-not-test.patch | 2.54 KB | Wim Leers |
Issue fork drupal-3291018
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
SpokjeSince this is a blocker for (at least) #3227033: Remove Quick Edit from core, which has Priority
Major, setting this one to that prio as well.Comment #4
Wim LeersZero remarks 🚀Ugh … this is moving a test that asserts that the work-around CSS for making CKEditor 5 work correctly in Quick Edit gets loaded when necessary. That work-around was introduced in #3194048: Enable Quick Edit support because #3196689: Remove legacy Quick Edit JS style changes is not yet fixed.
But if we're moving the test for the work-around out of
ckeditor5.module, I think we should also move the work-around out ofckeditor5.moduleand intoquickedit.module. Otherwise, the CKE5 module is providing the fix and the Quick Edit module is doing the test. That makes no sense, right?So, I think that we need to:
drupal.ckeditor5.quickedit-temporary-work-aroundlibrary + CSS fromckeditor5.libraries.ymltoquickedit.libraries.yml, and remove all references to it from the CKEditor 5 module.quickedit.inPlaceEditor.formattedTextis loaded: merge the files ofdrupal.ckeditor5.quickedit-temporary-work-aroundintoquickedit.inPlaceEditor.formattedText.Comment #5
Wim Leers… and I missed in #4 that there's also
core/modules/ckeditor5/css/quickedit.css. That too should move into the Quick Edit contrib module now. And could also always be loaded.Ah but … we have a similar problem for the CKEditor module:
core/modules/ckeditor/css/ckeditor.csscontains similar styles.Splitting that off into a separate issue: #3291047: Move Quick Edit-specific styling of CKEditor 4 & 5 into Quick Edit module.
Comment #6
Wim LeersTo help get you going on #4, I was thinking of something like this.
(Don't want to touch the MR so I can still RTBC 🤓)
Comment #7
SpokjeComment #8
SpokjeTwo remarks:
1) I couldn't get the original patch by @Wim Leers to pick up the "work-around CSS" all the time, so I resorted to the "if CKEditor5 module enabled" method, previously used the other way around ("if Quick Edit module enabled").
2) This might be a prime candidate to skip the Stable and Stable9 override CSS, since it's a temporary(?) workaround and having to use Stable/Stable9 means the original deprecation message can't be used any more.
Comment #9
SpokjeComment #10
Wim Leers🚢
Comment #12
catchCommitted/pushed to 10.0.x and 9.5.x, thanks!
Comment #14
SpokjeComment #15
SpokjeThe plain diff from
MR!2390should apply cleanly on9.4.x_after_ the commit of #3267258: Remove Quick Edit support from editor.module and #3291047: Move Quick Edit-specific styling of CKEditor 4 & 5 into Quick Edit module in that specific order.PP-2 for those two.
No deprecation errors to adjust in this one, but we need to update the CR when this gets committed.
Comment #16
SpokjeNot backporting this any more.