Closed (fixed)
Project:
Drupal core
Version:
9.5.x-dev
Component:
ckeditor.module
Priority:
Major
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
17 Jun 2022 at 08:54 UTC
Updated:
22 Jul 2022 at 12:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
wim leersComment #3
wim leersComment #5
wim leersThis means we now need
stableandstable9overrides 😬Comment #6
spokje- Green Testbot
- Patch created by "Mr. CKEditor(5)'
- Blocker for deprecating/removing Quick Edit
More than enough reasons for RTBC.
Comment #7
wim leershehe :P
One remark:
I'm not certain that these are necessary in this particular case. We're adding these CSS files to
stableandstable9even though Quick Edit is about to be removed.The better approach might be to add this library to
\Drupal\KernelTests\Core\Theme\StableLibraryOverrideTestBase::$librariesToSkipinstead.I'm not familiar enough with the policies around this to know — so leaving that up to the core committers/front end framework managers to decide 😊
If that approach is deemed better: start from #3, ignore #5, and just add
quickedit/quickedit.inPlaceEditor.formattedTextto\Drupal\KernelTests\Core\Theme\StableLibraryOverrideTestBase::$librariesToSkip.Comment #10
catchLooks good. Only hesitation about committing it is every time we do, we find another blocker...
Committed/pushed to 10.0.x and cherry-picked to 9.5.x, thanks!
I think it's OK if we remove the stable CSS at the same time as removing quickedit in 10.0.x.
Comment #11
wim leersWFM!
Comment #12
spokjeComment #13
spokjePatch
3291047-5.patchwill apply cleanly on 9.4.x after #3267258: Remove Quick Edit support from editor.module has been committed.Comment #14
spokjeNo deprecation errors to be changed in this one, there aren't any.
We should however update the CR when this gets committed.
Postponing on the commit of #3267258: Remove Quick Edit support from editor.module
Comment #15
spokjeComment #16
spokjeNot backporting this any more.