Automated Drupal 10 compatibility fixes

Reviewed / Tested the given patch #3.
works with drupal9 and Drupal10.
after applyig the patch and running throught the upgrade_status module there are no more deprication errors.

Moving this RTBC.

Rerolled patch as MR

I just tested the MR and it works as expected.

Thank you, Alex, Bart for maintaining the WebP important for performance and SEO module!

Hoping for a soft commit on the 8.x-1.x branch, to ease testing with Drupal 10.
A soft tag release ( pre-release ) would help speeding up work with Drupal ~10.0 using the composer.

Testing now with git clone --branch '8.x-1.x' https://git.drupalcode.org/project/webp.git
and git apply the patch or 29.diff

Had Real physical testing round for WebP 1.0.x-dev with Drupal ~10 and Drupal ~9

Attaching the Full testing round commands

Real-physical-testing-round-for-webp-1-0-x-dev--with-d10-and-d9.zip

Build Drupal ~10.0 sandbox test site and have Drush ~11.0

mkdir -p /var/www/html/sandboxes
composer create-project drupal/recommended-project:~10.0 /var/www/html/sandboxes/drupal10webp_1__test
cd /var/www/html/sandboxes/drupal10webp_1__test/
composer require drush/drush:~11.0;

Change minimum stability to dev for testing on the recommended Drupal 10 project template

composer config minimum-stability dev

Add the WebP module

mkdir -p /var/www/html/sandboxes/drupal10webp_1__test/web/modules/contrib
cd /var/www/html/sandboxes/drupal10webp_1__test/web/modules/contrib/
git clone --branch '8.x-1.x' https://git.drupalcode.org/project/webp.git

Git apply the needed patch

cd /var/www/html/sandboxes/drupal10webp_1__test/web/modules/contrib/webp/
wget https://git.drupalcode.org/project/webp/-/merge_requests/29.diff
git apply 29.diff

Change file/directory mod and ownership of files:

cd /var/www/html/sandboxes/drupal10webp_1__test/
sudo chmod 775 -R .;sudo chown www-data:$USER -R .;

Install with Drush

./vendor/drush/drush/drush site:install standard --yes --site-name="WebP 1.0.x-dev - Real physical testing with Drupal ~10" --account-name="webmaster" --account-pass="d" --account-mail="test@drupal.org" --db-url="mysql://root:123___@localhost/sandboxes_drupal10webp_1__test" -vvv ;

./vendor/drush/drush/drush pm:enable responsive_image
./vendor/drush/drush/drush pm:enable media
./vendor/drush/drush/drush pm:enable media_library
./vendor/drush/drush/drush pm:enable webp

Rebuild the cache:

sudo chmod 775 -R .;sudo chown www-data:$USER -R .;
./vendor/drush/drush/drush cache:rebuild

Open a browser and change the address to: http://localhost/sandboxes/drupal10webp_1__test/web/

Tested with configs on Media field with responsive Image styles in both Drupal 10 and Drupal 9

Tested, Ready for a release.

Seems to be ready

Tested and ready to release also.

Thanks for the hard work.

Tested and ready to release also.

Could we please have a d10-compatible release out soon so we don't have to patch? Thanks!

webp is one of our few remaining blockers to switch to D10 in our projects :(

Do we need this module for D10 since: https://www.drupal.org/node/3171135 ?

Yes, as this module offers fallback, while using WebP directly does not

That is true; #3213491: Add fallback format support to responsive images;
So if that issue is resolved, are there other important features missing?

Thanks Martijn

Support having this awesome feature in Drupal core

Modules like Image Styles too with Responsive Image Style
and contrib modules like Dynamic Responsive Image (or drimage) will switch from using Webp to the Drupal core solution.

I know I commented about it last week but 11k+ sites still use this module and will continue to use it until the core issue is fixed. Can we please have a d10-compatible release ASAP? The patch applies but patching doesn't work and `composer info drupal/webp` is still showing `requires
drupal/core ^8 || ^9`. Are the maintainers active on this project/in the comments? This is blocking d10 upgrades.

Thank you in advance for your support!

@jds1 did you test the core patch + Drupal Core WebP support? You don't need this module anymore if you don't have any edge cases I believe. It's all in Drupal Core. :)

as long it's not committed and released in core, this module has it's legitimacy. Some patches are inevitable, but any others I try to avoid - why? because sometimes these kind of patches land never or much later than you'd have expected. And sometimes it may become difficult to update because the patch must be re-rolled, or it may also conflict with another bugfix patch within the same core module,...

So, jds1 and I are just two examples for surely more people/organizations that will continue to use webp until Core provides an alternative in a regular release, hence also upgrading to 10.x is a blocker for us

Hey @martijin – thanks for responding :)

For this particular site that's currently in production we need a png fallback because it is possible some constituents are using older browsers. Plus the delta of updating all image styles to use core webp is much greater than updating one module. I will, without a doubt, use core webp support on all new projects moving forward though. It's real exciting stuff!!

Thank you agoradesign for another +1 for a release!

I'm gonna give it another day before I start messaging some of the maintainers to see if we can move this along. That will mean we can close this issue too!

thanks for messaging the maintainers :)

also thanks Martijn for testing and pushing the core issue forward. It will be great once we have this built in - hoping that will make other scenarios easier to handle (I've also used the webp support via imageapi_optimize dependent module + remote_stream_wrapper inside the same project and had to add glue code to combine both)

Hey everyone, apologies for the delay here. I can help get a D10-ready release out in the coming days.

Hey @mandclu – thank you so much for the quick follow-up today!! Much appreciated.

awesome :)

Thanks for the wealth of input on this issue. An 8.x-1.0-beta7 release is now available that is Drupal 10 compatible. I would like to further clean up the issue queue and move this module towards a stable release, so input on any issues currently labelled Needs Review would be much appreciated. Thanks again!