Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

CommentFileSizeAuthor
#25 3289138-25.patch3.63 KBfenstrat
#23 interdiff-3289138-22-23.txt900 bytesfenstrat
#23 3289138-23.patch3.87 KBfenstrat
#22 interdiff-3289138-21-22.txt907 bytesfenstrat
#22 3289138-22.patch2.99 KBfenstrat
#21 interdiff-3289138-20-21.txt1.11 KBfenstrat
#21 3289138-20.patch2.11 KBfenstrat
#20 3289138-20.patch1018 bytesfenstrat
#16 3289138-13.patch9.87 KBhimanshu_jhaloya
#12 3289138-12.patch367 bytesfenstrat
#10 3289138-10.patch361 bytesfenstrat
#7 3289138-6.patch1.41 KBfenstrat
#3 preview_site.1.x-dev.rector.patch4.04 KBproject update bot
#3 interdiff-last-bot.6644699.txt3.99 KBproject update bot
#2 preview_site.1.x-dev.rector.patch497 bytesproject update bot

Issue fork preview_site-3289138

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

project update bot commented
Status: Active » Needs review
StatusFileSize
new preview_site.1.x-dev.rector.patch497 bytes

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.12.0, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #127

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.9
  2. palantirnet/drupal-rector: 0.12.0
project update bot’s picture

project update bot commented
StatusFileSize
new interdiff-last-bot.6644699.txt3.99 KB
new preview_site.1.x-dev.rector.patch4.04 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.13.0, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #139

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.24
  2. palantirnet/drupal-rector: 0.13.0
project update bot’s picture

project update bot commented
Issue summary: View changes

Updating bot issue summary.See #3313904: Update project bot templates for RTBC status support and human interaction tips

  • larowlan committed 4f56fe8 on 1.x 
    Issue #3289138 by Project Update Bot: Automated Drupal 10 compatibility...

fenstrat credited larowlan.

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
commented
Issue summary: View changes
StatusFileSize
new 3289138-6.patch1.41 KB

Everything looks good in terms of D10 readiness. Here's the bump to core_version_requirement.

  • fenstrat committed 85113c27 on 1.x 
    Issue #3289138 by Project Update Bot, fenstrat, larowlan: Automated...
fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
commented
Status: Needs review » Fixed

Committed.

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
commented
Status: Fixed » Needs review
StatusFileSize
new 3289138-10.patch361 bytes

This broke D10 testing as only the 3.x branch of dynamic_entity_reference is D10 ready, this should fix that.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Needs work 
+++ b/composer.json
@@ -10,7 +10,7 @@
+        "drupal/dynamic_entity_reference": "~1 || ~2 || ~3",

Can you add 4 here too for those running v2

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
commented
Status: Needs work » Needs review
StatusFileSize
new 3289138-12.patch367 bytes

Haa sure! Almost did but noticed 4 wasn't stable. But adding it now makes sense.

himanshu_jhaloya made their first commit to this issue’s fork.

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
commented

Looks like the testbot is flaky (have tried a few runs), will try running again later.

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
commented

Just ran these locally and they're passing for me, the preview_site is not a directory issue the bot is having looks to be bot specific.

himanshu_jhaloya’s picture

himanshu_jhaloya commented
StatusFileSize
new 3289138-13.patch9.87 KB

I have applied the patch to fix some phpcs issue please review

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
commented

@himanshu_jhaloya can you create a new issue for PHPCS please.

After searching around Re the failure in #12 it looks like this because of the changes to composer.json, and is a bot specific issue. We've actually hit it before with this module in #3253050: Add a drush command for rebuilding preview sites, and others have in #3159928-19: uriScheme() method missing after update to Drupal 9 - both make changes to composer.json. As to why it happens, not sure. So I'm going to commit and then run the branch test, hopefully they pass.

  • fenstrat committed e39fd6b9 on 1.x 
    Issue #3289138 by fenstrat, larowlan: Drupal 10 fixes follow up to bump...
fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
commented
Assigned: Unassigned » fenstrat
Status: Needs review » Needs work

After the commit tests on 9.5 passed but failed on 10.0. Undefined constant "FILE_STATUS_PERMANENT" in preview_site_s3 - looks like the bot didn't pick up all the needed changes? Taking a look now.

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
commented
Status: Needs work » Needs review
StatusFileSize
new 3289138-20.patch1018 bytes

Looks like this should do it.

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
commented
StatusFileSize
new 3289138-20.patch2.11 KB
new interdiff-3289138-20-21.txt1.11 KB

Adds missing ->accessCheck(TRUE) to content entity queries.

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
commented
StatusFileSize
new 3289138-22.patch2.99 KB
new interdiff-3289138-21-22.txt907 bytes

Missed an accessCheck on a getAggregateQuery,

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
commented
StatusFileSize
new 3289138-23.patch3.87 KB
new interdiff-3289138-22-23.txt900 bytes

Updates the visibility condition as node_type is removed in D10.

Status: Needs review » Needs work

The last submitted patch, 23: 3289138-23.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
commented
Status: Needs work » Needs review
StatusFileSize
new 3289138-25.patch3.63 KB

This time with the correct context.

  • fenstrat committed df725d22 on 1.x 
    Issue #3289138 by fenstrat: Drupal 10 compatibility fixes follow ups.
fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
commented
Status: Needs review » Fixed

Committed! Branch tests are passing on 9.5 and 10.0, yay.

Will cut a new release.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.