Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

Status: Active » Needs review
StatusFileSize
new2.57 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.12.0, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #127

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.9
  2. palantirnet/drupal-rector: 0.12.0

Status: Needs review » Needs work

The last submitted patch, 2: friendlycaptcha.1.x-dev.rector.patch, failed testing. View results

anybody’s picture

Issue summary: View changes

Needs work. Tests are failing with "Invalid permission administer content types."

reenaraghavan’s picture

Assigned: Unassigned » reenaraghavan

reenaraghavan’s picture

Assigned: reenaraghavan » Unassigned
StatusFileSize
new92.17 KB
new66.13 KB

Tested using Rector.
Tested using Drupal check and found few errors
------ ---------------------------------------------------------------------
Line friendlycaptcha.module
------ ---------------------------------------------------------------------
92 Function captcha_captcha not found.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
------ ---------------------------------------------------------------------

------ ---------------------------------------------------------------------
Line tests/src/Functional/FriendlyCaptchaBasicTest.php
------ ---------------------------------------------------------------------
50 Call to deprecated function module_load_include():
in drupal:9.4.0 and is removed from drupal:11.0.0.
Use \Drupal::moduleHandler()->loadInclude($module, $type, $name =
NULL).
Note that including code from uninstalled extensions is no longer
supported.
154 Function captcha_set_form_id_setting not found.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
161 Function captcha_set_form_id_setting not found.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
162 Function captcha_get_form_id_setting not found.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
163 Method PHPUnit\Framework\Assert::assertNotNull() invoked with 3
parameters, 1-2 required.
------ ---------------------------------------------------------------------

[ERROR] Found 6 errors

Also attached screenshot of errors found after scanning the module using Upgrade Status.

project update bot’s picture

Status: Needs work » Needs review
StatusFileSize
new354 bytes
new2.83 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.13.1, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #145

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.25
  2. palantirnet/drupal-rector: 0.13.1

Status: Needs review » Needs work

The last submitted patch, 8: friendlycaptcha.1.x-dev.rector.patch, failed testing. View results

webflo’s picture

Status: Needs work » Needs review
StatusFileSize
new8.15 KB

  • webflo committed 5c080bc on 1.x
    Issue #3287690 by Project Update Bot, webflo: Automated Drupal 10...
webflo’s picture

  • webflo committed 3914e2f on 1.x
    Issue #3287690: Update path in docs and Drupal 10 compatibility
    
anybody’s picture

Status: Needs review » Needs work

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

So we'll simply wait for further patches here!

jatingupta40’s picture

@Anybody Can you please list the errors that the upgrade_module is showing you because for me the module is compatible and just showing 4 errors that are not related to the module's compatibility but related to the library not being installed.

anybody’s picture

@JatinGupta40 this was a quote from #8-

Did you check the current state of this module using Upgrade Status? Would you suggest to close this issue then?

mmjvb’s picture

Status: Needs work » Active

Set to Active to allow the bot to post further fixes. As the patch was committed there is no work to be done. The test failure was resolved. Just to wait for other automated fixes.

Already released as D10 compatible, maintainer decided not to close!

grevil’s picture

Title: Automated Drupal 10 compatibility fixes » [FIXED] Automated Drupal 10 compatibility fixes

@Anybody, I can confirm that the current dev version is Drupal 10 conform, I checked this via "phpstan-drupal" and "upgrade_status" accordingly.

anybody’s picture

Title: [FIXED] Automated Drupal 10 compatibility fixes » Automated Drupal 10 compatibility fixes [FIXED]

So this is officially FIXED! :)

Leaving this open for the bot.

project update bot’s picture

Issue summary: View changes
anybody’s picture

Issue summary: View changes
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.