Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

Status: Active » Needs review
StatusFileSize
new394 bytes

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module this patch makes this module compatible with Drupal 10! 🎉
This patch updates the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #127

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.9
  2. palantirnet/drupal-rector: 0.12.0
project update bot’s picture

Issue summary: View changes
yookoala’s picture

Issue summary: View changes

Been using the module a great deal. Thanks a lot.
Please update the module for Drupal 10 as soon as possible.

Rinku Jacob 13 made their first commit to this issue’s fork.

rinku jacob 13’s picture

Created a new MR based on the patch for easy review.

sahil.goyal’s picture

StatusFileSize
new377 bytes
new369 bytes
new62.4 KB

Hi @Rinku Jacob 13 the MR is not correct, .info file contains issues, which giving errors for string pre-processed, So, i updating a patch again and tested module is not working as expected to the D10.1.x.

yashingole’s picture

StatusFileSize
new162.45 KB
new24.33 KB

I have reviewed and checked Patch #8 this works for drupal 9.5 and drupal 10.0. and 10.0.1
Screenshots of the compatibility on 9.5 and the Edit page on 10 have been attached for reference:

Ranjit1032002 made their first commit to this issue’s fork.

ranjit1032002’s picture

Created MR for the issue metioned in comment #8 , please review.

Thank you.

webdrips’s picture

Neither #8 nor #12 applied correctly for me on 2.1 (applying patches via composer).

chike’s picture

@Project Update Bot's patch #2 applied on 10.1.1 and module is working fine.

webdrips’s picture

@chike I agree, thanks for posting that. The module now passes the upgrade status check.

hyperlinked’s picture

Status: Needs review » Reviewed & tested by the community

Disregard my last comment about merging the commit into the 8.x-2.x branch. That was the wrong commit. All of the user submitted patches are incorrect. The one that needs to be merged is the one from Project Update Bot #2 as verified by @webdrips.

gisle made their first commit to this issue’s fork.

slivorezka’s picture

Assigned: Unassigned » slivorezka
slivorezka’s picture

Status: Reviewed & tested by the community » Fixed
slivorezka’s picture

Assigned: slivorezka » Unassigned
slivorezka’s picture

Status: Fixed » Closed (fixed)