Problem/Motivation

CSS Styles for duration field do not work in GIN Theme

Steps to reproduce

Add a duration field and go to /node/type/edit Maybe you need to set GIN as admin theme.

You will see that the fields for "Hours" and "Minutes" are stacked. And have not applied any of the styles defined in modules (S)CSS

Problem

CSS selectors form-type-number and form-type-duration look (other theme?) look in Gin like form-type--number and form-type--duration

Proposed resolution

Duplicate the selectors. Use form-type-duration AND form-type--duration
in SCSS. This is not much of a performance issue and will solve any case. Maybe someone can dig deeper to find the cause.

CommentFileSizeAuthor
#8 Screen Shot 2022-10-13 at 5.42.51 PM.png8.11 KBjrockowitz
#4 duration_field-3284489.patch2.12 KBdigitaldonkey

Issue fork duration_field-3284489

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

digitaldonkey created an issue. See original summary.

digitaldonkey’s picture

digitaldonkey commented
Issue summary: View changes

digitaldonkey opened merge request !1

digitaldonkey’s picture

digitaldonkey commented
StatusFileSize
new duration_field-3284489.patch2.12 KB

Patch from PR above

digitaldonkey’s picture

digitaldonkey commented
Assigned: digitaldonkey » Unassigned
Status: Active » Needs review
digitaldonkey’s picture

digitaldonkey commented
djdevin’s picture

djdevin
he/him
Primary language English
Location Philadelphia
commented
Version: 8.x-2.0 » 8.x-2.x-dev
Status: Needs review » Reviewed & tested by the community

Tested against Claro too.

jrockowitz’s picture

jrockowitz commented
StatusFileSize
new Screen Shot 2022-10-13 at 5.42.51 PM.png8.11 KB

Tested against Gin.

Jaypan made their first commit to this issue’s fork.

  • Jaypan committed bb0102d on 8.x-2.x authored by digitaldonkey 
    Issue #3284489 by digitaldonkey: CSS Styles for duration field  are not...
jaypan’s picture

jaypan
Location Victoria, BC
commented
Status: Reviewed & tested by the community » Fixed

  • 1c193d8 committed on 3.0.x 
    Issue #3284489 by digitaldonkey, Jaypan, jrockowitz, djdevin: CSS Styles...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.