I'm getting the following warning when creating a new Quick Tabs instance:

Warning: Trying to access array offset on value of type null in Drupal\quicktabs_accordion\Plugin\TabRenderer\AccordionTabs->optionsForm() (line 26 of modules/contrib/quicktabs/quicktabs_accordion/src/Plugin/TabRenderer/AccordionTabs.php).
Drupal\quicktabs_accordion\Plugin\TabRenderer\AccordionTabs->optionsForm(Object) (Line: 112)

CommentFileSizeAuthor
#6 After-MR.png581.04 KBnikhil_110
#6 Before-MR.png1.12 MBnikhil_110
#2 3280824.patch619 bytesgloomcheng

Issue fork quicktabs-3280824

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

gloomcheng created an issue. See original summary.

gloomcheng’s picture

gloomcheng commented
StatusFileSize
new 3280824.patch619 bytes

Attached patch could fix it.

NickDickinsonWilde made their first commit to this issue’s fork.

NickDickinsonWilde opened merge request !9

nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented
Title: Warning on line 26 of modules/contrib/quicktabs/quicktabs_accordion/src/Plugin/TabRenderer/AccordionTabs.php » Accordion Tabs config isn't initialized on Quick Tab instance edit form
Status: Active » Needs review

Thanks @gloomcheng for the patch/report. I've expanded it a bit and created a MR which is ready for review.

nikhil_110’s picture

nikhil_110 commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Before-MR.png1.12 MB
new After-MR.png581.04 KB

The above MR is applied successfully for Quick Tabs v8.x-3.0-alpha5.
After applying MR the warning messages that show us on the "Add Quick Tabs Instance" page are removed.
Attaching the screenshot for reference.

Test Setps

smustgrave closed merge request !9

  • smustgrave committed 1d3c0e4f on 4.0.x 
    Issue #3280824 by nickdickinsonwilde, gloomcheng, nikhil_110: Accordion...
smustgrave’s picture

smustgrave commented
Version: 8.x-3.0-alpha5 » 4.0.x-dev
Status: Reviewed & tested by the community » Fixed

Committed to new 4.0.x branch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.