Closed (fixed)
Project:
Bootstrap5
Version:
2.0.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
27 Apr 2022 at 15:46 UTC
Updated:
13 Feb 2023 at 15:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
stefan.kornComment #3
ressaThanks @stefan.korn, your patch makes the mark up more in line with Bootstrap. However, applying this patch alone makes the "View" tab look funny, but if I add the patch from #3277454: Active local task should carry nav-link class as well, it looks better. So perhaps close that issue, and add the patch here, for a combined solution?
Comment #4
rbruch commentedNow that #3277454 has landed in 2.0.6, the View tab has two borders, one on the
<li>tag and one on the<a>tag. This is because of this issue, i.e., the<li>tag has thenav-linkclass, when it should not. The Bootstrap docs are clear for both Bootstrap 5.1 and Bootstrap 5.2: the<li>tag should have thenav-itemclass, and the<a>tag should have thenav-linkclass.Can we get this patch included in version Bootstrap5 theme version 2.0.x, as well as possibly version 3.0.x?
Comment #5
rbruch commentedComment #6
mustanggb commentedI'm seeing the same as rbruch, since 2.0.6 active tabs now have a double border.
Removing
nav-linkfrom the<li>does fix it.Comment #7
crutch commentedUsing this for now seems to work well.
Comment #8
jannakha commentedthis patch is working as expected.
please merge to v2 and v3
Comment #9
vladimirausComment #12
vladimirausThank you! Committed! 🥃