Problem/Motivation

An active local task does not get the bootstrap "nav-link" class, while Bootstrap it self uses the "nav-link" class on active items too. This can be seen in the Bootstrap examples: https://getbootstrap.com/docs/5.1/components/navs-tabs/

Steps to reproduce

Check the active item in a nav tab element in bootstrap5 theme (e. g. the view tab of the node operations when logged in). The view tab is the active tab and it does not get the "nav-link" class, just, the "active and is-active" classes. The other tabs get the "nav-link" class.

Proposed resolution

Add "nav-link" class in preprocess function to active item as well.

Remaining tasks

create a patch

User interface changes

Active tabs will get the bootstrap class "nav-link" and therefore behave as expected from vanilla bootstrap.

API changes

none

Data model changes

none

Comments

stefan.korn created an issue. See original summary.

stefan.korn’s picture

Assigned: stefan.korn » Unassigned
Status: Active » Needs review
StatusFileSize
new643 bytes
jannakha’s picture

Status: Needs review » Reviewed & tested by the community

ok

vladimiraus’s picture

Version: 1.1.x-dev » 3.0.x-dev
Status: Reviewed & tested by the community » Fixed

Fixed. Thank you. 🍹
Applied to both branches 2.0.x and 3.0.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.