Support Drupal 10 and update all use of deprecation in the Admin Audit Trail module [#3277440]

Problem/Motivation

Drupal 10.0.0 stable was released on: 15 Dec 2022 by the Drupal core team
https://www.drupal.org/project/drupal/releases/10.0.0

Thank you so much!

Further drupal-check on

composer create-project drupal/recommended-project:~10.0 /var/www/html/sandboxes/drupal10admin_audit_trail

cd /var/www/html/sandboxes/drupal10admin_audit_trail/

composer config minimum-stability dev

composer require drupal/admin_audit_trail

composer require mglaman/drupal-check --dev
composer require phpspec/prophecy-phpunit:^2 --dev 

php vendor/bin/drupal-check -d web/modules/contrib/admin_audit_trail/

Output:

admin_audit_trail--drupal-check--report.txt

Proposed resolution

Support Drupal ~10 and change all deprecated packages, classes, functions, asset libraries to the Drupal 10 way
Real physical testing with Drupal ~10
Automated upgrade to Drupal ~10

Remaining tasks

✅ File an issue
✅ Addition/Change/Update/Fix
✅ Testing to ensure no regression
➖ Automated unit testing coverage
➖ Automated functional testing coverage
➖ UX/UI designer responsibilities
➖ Readability
➖ Accessibility
✅ Performance
➖ Security
➖ Documentation
✅ Code review by maintainers
✅ Full testing and approval
✅ Credit contributors
✅ Review with the product owner
✅ Release notes snippet
✅ Release admin_audit_trail-1.0.1

API changes

Data model changes

Release notes snippet

Issue #3277440: Support Drupal 10 and update all use of deprecation in the Admin Audit Trail module

Comment	File	Size	Author
#15	Screenshot 2022-05-27 at 12.55.52 PM.png	342.96 KB	rassoni
#10	admin_audit_trail--drupal-check--report.txt	3.97 KB	rajab natshah

Comments

Comment #1

27 April 2022 at 14:45

Rajab Natshah created an issue. See original summary.

Comment #2

rajab natshah

he/him

commented 27 April 2022 at 14:46

Comment #3

rajab natshah

he/him

commented 27 April 2022 at 14:47

Title:

Support Drupal 10 and update all use of depricatoins in the Admin Audit Trail module

» Support Drupal 10 and update all use of deprecations in the Admin Audit Trail module

Comment #4

5 May 2022 at 08:32

Rajab Natshah committed 3e47313 on 1.0.x

Issue #3277440: Support Drupal 10 and update all use of deprecations in...

Comment #5

rajab natshah

he/him

commented 5 May 2022 at 08:34

Status:

Active

» Needs review

Comment #6

rajab natshah

he/him

commented 5 May 2022 at 08:45

Issue summary:

View changes

Comment #7

rajab natshah

he/him

commented 8 May 2022 at 16:35

Issue summary:

View changes

Comment #8

9 May 2022 at 16:49

Rajab Natshah committed 5df60ff on 1.0.x

Issue #3277440: Support Drupal 10 and update all use of deprecations in...

Comment #9

rajab natshah

he/him

commented 10 May 2022 at 08:37

Issue tags:

+Drupal 10 compatibility

Comment #10

rajab natshah

he/him

commented 11 May 2022 at 08:56

Issue summary:	View changes
Status:	Needs review	» Needs work

Status	File	Size
new	admin_audit_trail--drupal-check--report.txt	3.97 KB

Further drupal-check on

composer create-project drupal/recommended-project:10.0.0-alpha4@alpha /var/www/html/sandboxes/drupal10admin_audit_trail

cd /var/www/html/sandboxes/drupal10admin_audit_trail/

composer require drupal/admin_audit_trail

composer require mglaman/drupal-check --dev
composer require phpspec/prophecy-phpunit:^2 --dev 

php vendor/bin/drupal-check -d web/modules/contrib/admin_audit_trail/

Output:

admin_audit_trail--drupal-check--report.txt

 ------ ------------------------------------------------------------------- 
  Line   admin_audit_trail.module                                           
 ------ ------------------------------------------------------------------- 
  133    Access to an undefined property                                    
         Drupal\Core\Form\FormStateInterface::$__admin_audit_trail_logged.  
 ------ ------------------------------------------------------------------- 

 ------ ------------------------------------------------------ 
  Line   admin_audit_trail_file/admin_audit_trail_file.module  
 ------ ------------------------------------------------------ 
  30     Call to an undefined method                           
         Drupal\Core\Entity\EntityInterface::getFileUri().     
  32     Call to an undefined method                           
         Drupal\Core\Entity\EntityInterface::getFilename().    
  46     Call to an undefined method                           
         Drupal\Core\Entity\EntityInterface::getFileUri().     
  48     Call to an undefined method                           
         Drupal\Core\Entity\EntityInterface::getFilename().    
  62     Call to an undefined method                           
         Drupal\Core\Entity\EntityInterface::getFileUri().     
  64     Call to an undefined method                           
         Drupal\Core\Entity\EntityInterface::getFilename().    
 ------ ------------------------------------------------------ 

 ------ -------------------------------------------------------------- 
  Line   admin_audit_trail_media/admin_audit_trail_media.module        
 ------ -------------------------------------------------------------- 
  33     Call to an undefined method                                   
         Drupal\Core\Entity\EntityInterface::getName().                
  34     Call to an undefined method                                   
         Drupal\Core\Entity\EntityInterface::getRevisionLogMessage().  
  34     Call to an undefined method                                   
         Drupal\Core\Entity\EntityInterface::getRevisionLogMessage().  
  53     Call to an undefined method                                   
         Drupal\Core\Entity\EntityInterface::getName().                
  54     Call to an undefined method                                   
         Drupal\Core\Entity\EntityInterface::getRevisionLogMessage().  
  54     Call to an undefined method                                   
         Drupal\Core\Entity\EntityInterface::getRevisionLogMessage().  
  73     Call to an undefined method                                   
         Drupal\Core\Entity\EntityInterface::getName().                
  74     Call to an undefined method                                   
         Drupal\Core\Entity\EntityInterface::getRevisionLogMessage().  
  74     Call to an undefined method                                   
         Drupal\Core\Entity\EntityInterface::getRevisionLogMessage().  
 ------ -------------------------------------------------------------- 

 ------ ------------------------------------------------------------------ 
  Line   src/AdminAuditTrailStorage.php                                    
 ------ ------------------------------------------------------------------ 
  29     Call to an undefined method                                       
         Drupal\Core\Database\Query\ExtendableInterface::orderByHeader().  
 ------ ------------------------------------------------------------------ 

 ------ ----------------------------------------------------------------- 
  Line   src/OverviewForm.php                                             
 ------ ----------------------------------------------------------------- 
  79     Method Drupal\admin_audit_trail\OverviewForm::getUserData() has  
         invalid return type Drupal\admin_audit_trail\Drupal\Core\Link.   
 ------ ----------------------------------------------------------------- 

 [ERROR] Found 18 errors

Comment #11

rajab natshah

he/him

commented 11 May 2022 at 09:00

Title:

Support Drupal 10 and update all use of deprecations in the Admin Audit Trail module

» Support Drupal 10 and update all use of deprecation in the Admin Audit Trail module

Comment #12

rajab natshah

he/him

commented 11 May 2022 at 10:44

Assigned:

rajab natshah

» Unassigned

Comment #13

rajab natshah

he/him

commented 11 May 2022 at 12:11

Issue summary:

View changes

Comment #14

rajab natshah

he/him

commented 18 May 2022 at 16:35

Issue summary:

View changes

Comment #15

rassoni commented 27 May 2022 at 07:35

Status:

Needs work

» Reviewed & tested by the community

Status	File	Size
new	Screenshot 2022-05-27 at 12.55.52 PM.png	342.96 KB

Please find the attached patch and check the screenshot for reference.

Comment #16

rassoni commented 27 May 2022 at 07:36

Status:

Reviewed & tested by the community

» Needs review

Comment #17

rajab natshah

he/him

commented 27 May 2022 at 19:32

Status:

Needs review

» Needs work

No change to code was proposed.
Back to Needs work

Comment #18

rajab natshah

he/him

commented 9 June 2022 at 08:18

Issue summary:

View changes

Comment #19

rajab natshah

he/him

commented 8 October 2022 at 10:01

Further drupal-check on

mkdir -p /var/www/html/sandboxes
cd /var/www/html/sandboxes

composer create-project drupal/recommended-project:~9.0 drupal9admin_audit_trail

cd /var/www/html/sandboxes/drupal9admin_audit_trail/

composer require drupal/admin_audit_trail:1.0.x-dev

composer require drupal/core-dev --dev
composer require mglaman/drupal-check --dev
composer require phpspec/prophecy-phpunit --dev 

php vendor/bin/drupal-check -d web/modules/contrib/admin_audit_trail/

The output

16/16 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ------------------------------------------------------------------- 
  Line   admin_audit_trail.module                                           
 ------ ------------------------------------------------------------------- 
  136    Access to an undefined property                                    
         Drupal\Core\Form\FormStateInterface::$__admin_audit_trail_logged.  
 ------ ------------------------------------------------------------------- 

 ------ ------------------------------------------------------ 
  Line   admin_audit_trail_file/admin_audit_trail_file.module  
 ------ ------------------------------------------------------ 
  30     Call to an undefined method                           
         Drupal\Core\Entity\EntityInterface::getFileUri().     
  32     Call to an undefined method                           
         Drupal\Core\Entity\EntityInterface::getFilename().    
  46     Call to an undefined method                           
         Drupal\Core\Entity\EntityInterface::getFileUri().     
  48     Call to an undefined method                           
         Drupal\Core\Entity\EntityInterface::getFilename().    
  62     Call to an undefined method                           
         Drupal\Core\Entity\EntityInterface::getFileUri().     
  64     Call to an undefined method                           
         Drupal\Core\Entity\EntityInterface::getFilename().    
 ------ ------------------------------------------------------ 

 ------ -------------------------------------------------------------- 
  Line   admin_audit_trail_media/admin_audit_trail_media.module        
 ------ -------------------------------------------------------------- 
  32     Call to an undefined method                                   
         Drupal\Core\Entity\EntityInterface::getName().                
  33     Call to an undefined method                                   
         Drupal\Core\Entity\EntityInterface::getRevisionLogMessage().  
  33     Call to an undefined method                                   
         Drupal\Core\Entity\EntityInterface::getRevisionLogMessage().  
  52     Call to an undefined method                                   
         Drupal\Core\Entity\EntityInterface::getName().                
  53     Call to an undefined method                                   
         Drupal\Core\Entity\EntityInterface::getRevisionLogMessage().  
  53     Call to an undefined method                                   
         Drupal\Core\Entity\EntityInterface::getRevisionLogMessage().  
  72     Call to an undefined method                                   
         Drupal\Core\Entity\EntityInterface::getName().                
  73     Call to an undefined method                                   
         Drupal\Core\Entity\EntityInterface::getRevisionLogMessage().  
  73     Call to an undefined method                                   
         Drupal\Core\Entity\EntityInterface::getRevisionLogMessage().  
 ------ -------------------------------------------------------------- 

 ------ ------------------------------------------------------------------ 
  Line   src/AdminAuditTrailStorage.php                                    
 ------ ------------------------------------------------------------------ 
  29     Call to an undefined method                                       
         Drupal\Core\Database\Query\ExtendableInterface::orderByHeader().  
 ------ ------------------------------------------------------------------ 

 ------ ----------------------------------------------------------------- 
  Line   src/OverviewForm.php                                             
 ------ ----------------------------------------------------------------- 
  79     Method Drupal\admin_audit_trail\OverviewForm::getUserData() has  
         invalid return type Drupal\admin_audit_trail\Drupal\Core\Link.   
 ------ ----------------------------------------------------------------- 

 [ERROR] Found 18 errors                                                        

Thanks for using drupal-check!

Consider sponsoring the development of the maintainers which make drupal-check possible:

- phpstan (ondrejmirtes): https://github.com/sponsors/ondrejmirtes
- phpstan-deprecation-rules (ondrejmirtes)): https://github.com/sponsors/ondrejmirtes
- phpstan-drupal (mglaman)): https://github.com/sponsors/mglaman
- drupal-check (mglaman)): https://github.com/sponsors/mglaman

Comment #20

rajab natshah

he/him

commented 8 October 2022 at 12:19

No issues with Drupal standards and Drupal Practice

phpcs --standard=Drupal

rajab@vardot-dev:/var/www/html/products/admin_audit_trail$ phpcbf --standard=Drupal --extensions=php,module,inc,install,test,theme,scss,less,css,info,txt,md /var/www/html/products/admin_audit_trail --ignore="/var/www/html/products/admin_audit_trail/node_modules/"

phpcs--standard=DrupalPractice

rajab@vardot-dev:/var/www/html/products/admin_audit_trail$ phpcbf --standard=DrupalPractice --extensions=php,module,inc,install,test,theme,scss,less,css,info,txt,md /var/www/html/products/admin_audit_trail --ignore="/var/www/html/products/admin_audit_trail/node_modules/"

Comment #21

8 October 2022 at 16:51

Rajab Natshah committed 899cd96 on 1.0.x

Issue #3277440: Support Drupal 10 and update all use of deprecation in...

Comment #22

rajab natshah

he/him

commented 8 October 2022 at 16:53

Assigned:	Unassigned	» mohammed j. razem
Issue summary:	View changes
Issue tags:		+admin_audit_trail-1.0.1

Comment #23

rajab natshah

he/him

commented 8 October 2022 at 16:54

Assigned:

mohammed j. razem

» Unassigned

Comment #24

rajab natshah

he/him

commented 8 October 2022 at 16:54

Status:

Needs work

» Needs review

Comment #25

rajab natshah

he/him

commented 8 October 2022 at 16:54

Status:

Needs review

» Fixed

Comment #26

rajab natshah

he/him

commented 8 October 2022 at 17:01

Issue summary:

View changes

✅ Released admin_audit_trail-1.0.1

Comment #27

22 October 2022 at 17:04

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Comment #28

rajab natshah

he/him

commented 8 January 2023 at 08:09

Issue summary:

View changes

Support Drupal 10 and update all use of deprecation in the Admin Audit Trail module

Problem/Motivation

Further drupal-check on

Output:

Proposed resolution

Remaining tasks

API changes

Data model changes

Release notes snippet

Comments

Further drupal-check on

Output:

Further drupal-check on

Related issues

Referenced by