Deprecated function: Return type of GuzzleHttp\Cookie\CookieJar when running Upgrade Status on PHP 8.1

Hello @neclimdul,

Thanks for the patch,
I will review the patch

Hello @neclimdul,

After installing and/or enabling the module using composer command:
composer require 'drupal/upgrade_status:^3.14'.

Using patch #3, it gets applied easily but while scan process it encountered following error:

hence shifting the issue status to needs work.

Thanks and regards.

hey @akshaydalvi212, can you please check the src/CookieJar.php file is created inside this module's folder or not (for mine it's created on root folder).
can you please show commands you run to apply this patch #3?

There were also existing fails on PHP 7.4 and 8.0 which I just fixed in #3302828: Upgrade Status tests fail on PHP 7.4 and PHP 8.0 due to lack of rules.neon used from phpstan-drupal, so let's run this on all the environments.

In #3302828: Upgrade Status tests fail on PHP 7.4 and PHP 8.0 due to lack of rules.neon used from phpstan-drupal the PHP 8.1 environment was still failing with this error. Providing our own CookieJar sounds like a reasonable stopgap, so let's do this!

Now I get another error:

PHP message: PHP Fatal error: Declaration of Drupal\upgrade_status\CookieJar::withCookieHeader(Psr\Http\Message\RequestInterface $request) must be compatible with GuzzleHttp\Cookie\CookieJarInterface::withCookieHeader(Psr\Http\Message\RequestInterface $request): Psr\Http\Message\RequestInterface in /upgrade_status/src/CookieJar.php on line 28

As stated in above patch #3 inside Drupal\upgrade_status\CookieJar.php file if the core have guzzlehttp/guzzle version 7, then no need for CookieJar.php in module itself.

As mentioned by lobodacyril, that has now become more severe, actually breaking with today's upgrade_status HEAD, Drupal current stable 9.4.6 and PHP 8.1.10.

Same issue with Drupal 9.5.0-beta1 so not minor, but actually major since it is broken on both a stable version and the upcoming new stable.

Fatal error: Declaration of Drupal\upgrade_status\CookieJar::withCookieHeader(Psr\Http\Message\RequestInterface $request) must be compatible with GuzzleHttp\Cookie\CookieJarInterface::withCookieHeader(Psr\Http\Message\RequestInterface $request): Psr\Http\Message\RequestInterface in /Users/fgm/src/Drupal/d9/drop9/web/modules/contrib/upgrade_status/src/CookieJar.php on line 284

So what do we do then, should we remove our override and depend on which Guzzle the setup takes?

Patch in #20 is not enough for Drupal core 9.5.0-beta2.

+++ b/src/CookieJar.php
@@ -239,7 +239,7 @@ class CookieJar implements CookieJarInterface
-    ) {
+    ) :void {

Updated a little bit here

< + ) :void {
---
> + ): void {

Facing the same issue
Switched to test and work with:

  "require-dev": {
    "drupal/upgrade_status": "3.x-dev",
    "drupal/core-dev": "~9.0",
    "drush/drush": "~11.0",
    "mglaman/drupal-check": "~1.0",
    "phpspec/prophecy-phpunit": "~2.0"
  },

Patch in #22 is needed to work in PHP 8.0 and PHP 8.1

    "patches": {
      "drupal/upgrade_status": {
        "Issue #3274645: Deprecated function: Return type of GuzzleHttp Cookie CookieJar when running Upgrade Status on PHP 8.1":
        "https://www.drupal.org/files/issues/2022-10-07/3274645-22.patch"
      }
    }

It feels that this issue fix might be better in a new issue.

Any news here? This is a blocker for using the module with PHP 8.1

Did you try this patch for Guzzle 6.5?

I'm already on PHP 8.1, so Guzzle 7

Sorry for the delay, committed. Will make a release shortly unless there are other pressing things too.

https://www.drupal.org/project/upgrade_status/releases/8.x-3.18 out now, enjoy! Also please use new issues for followups for better tracking. Thanks a lot!