Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#9 3271337-9.patch17.84 KBacbramley
#8 3271337-8.patch18.09 KBacbramley
#6 3271337.patch15.14 KBlarowlan

Issue fork search_api_opensearch-3271337

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

larowlan created an issue. See original summary.

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented

Could this be done under a "Support search_api_autocomplete" issue?

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Assigned: Unassigned » larowlan

larowlan opened merge request !9

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

Pushed WIP to MR, seems to be working locally

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
StatusFileSize
new 3271337.patch15.14 KB

Patch for those who want it

acbramley made their first commit to this issue’s fork.

acbramley’s picture

acbramley commented
Status: Active » Needs review
StatusFileSize
new 3271337-8.patch18.09 KB

Pushed Edge N-gram support and updates settings based on https://opensearch.org/docs/latest/opensearch/ux/#sample-request-2

acbramley’s picture

acbramley commented
StatusFileSize
new 3271337-9.patch17.84 KB

Re-rolled

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented 
  1. +++ b/src/Analyser/AnalyserManager.php
@@ -0,0 +1,34 @@
+    $this->alterInfo('opensearch_analyser_info');

    Does this need to match the module name? 

  2. +++ b/src/SearchAPI/BackendClient.php
@@ -91,8 +99,10 @@ class BackendClient implements BackendClientInterface {
+  public function __construct(QueryParamBuilder $queryParamBuilder, QueryResultParser $resultParser, IndexParamBuilder $indexParamBuilder, FieldsHelperInterface $fieldsHelper, FieldMapper $fieldParamsBuilder, LoggerInterface $logger, Client $client, array $settings, protected AnalyserManager $analyserManager) {

    Should we do constructor property promotion all in one go, rather than mixing it here?

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

Does this need to match the module name?

I just copied it from the existing pattern for the backend connectors

  • kim.pepper committed fb4b8fa on 1.x authored by acbramley 
    Issue #3271337 by acbramley, larowlan: Add native support for n-gram and...
kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented
Status: Needs review » Fixed

Committed and pushed to 1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

kim.pepper closed merge request !9