If you don't set the "version" of a profile, the report/status displays an empty dash

Hi! I follow the steps to reproduce the error and was able to reproduce. With the Proposed Resolution, the error was fixed and even if the "version" key is not set in mininal.info.yml file, the page will not empty. So I opened a merge request to fix it.

I'm not sure this is the right fix.

Any profile you download from d.org will have the version filled in, won't it?

So the profiles that don't have this will be custom in-house install profiles that are used to install multiple sites. In that situation, using Drupal's core version number doesn't make sense to me.

I think it might be better to show 'Undefined'.

It doesn't make sense for me too. It would mean that the same profile, installed for different Drupal versions, would show a different version.

IMO, it doesn't make sense to show, for example, Minimal (minimal-9.3-12-dev) nor Minimal (minimal-undefined). I would just show the profile name and the version, when it has been set (Minimal (9.3-12-dev) or Minimal). At least, it would be consistent with the versions shown for modules, which aren't prefixed by the module machine name. (It doesn't show node-9.3.18-dev, for the Node module.)

Applied the MR and it fixed the problem following the Proposed resolution.
Changing this to RTBC.
Following a screenshot with the changes applied.

The patch in #13, which was supposed to fail, failed because Your XML configuration validates against a deprecated schema. which isn't the expected failure.

I was referring to this sentence in that comment.

since it's a bug I've upload a TEST-ONLY patch, so it's supposed to fail here.

I take you are expecting that patch fails, but I take you aren't talking about the Your XML configuration validates against a deprecated schema. failure. What failure should that test patch show, then?

Sure

@alexverb - Can you create an MR with your change in this issue? I agree just using a string output here makes sense.

+
+      $profile_value = $info['version'] ? '%profile_name (%profile-%version)' : '%profile_name (%profile)';
       $requirements['install_profile'] = [
         'title' => t('Installation profile'),
-        'value' => t('%profile_name (%profile-%version)', [
-          '%profile_name' => $info['name'],
-          '%profile' => $profile,
-          '%version' => $info['version'],
-        ]),
+        'value' => $info['name'] . ' (' . $profile . ($info['version'] ? '-' . $info['version'] : '') . ')',
         'severity' => REQUIREMENT_INFO,
         'weight' => -9,

$profile_value is set but never used. That's why core/scripts/dev/commit-code-check.sh --drupalci fails.

I don't think if we need $profile_value variable anymore so I've removed it. Please review.

Addressed #34 concern
Please review this

In PHP 8.1 this shows an error, at least when running ./vendor/bin/drush core:requirements:

Deprecated function: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in Drupal\Component\Utility\Html::escape() (line 424 of web/core/lib/Drupal/Component/Utility/Html.php)
#0 web/core/includes/bootstrap.inc(347): _drupal_error_handler_real(8192, 'htmlspecialchar...', '...', 424)
#1 [internal function]: _drupal_error_handler(8192, 'htmlspecialchar...', '...', 424)
#2 web/core/lib/Drupal/Component/Utility/Html.php(424): htmlspecialchars(NULL, 11, 'UTF-8')
#3 web/core/lib/Drupal/Component/Render/FormattableMarkup.php(262): Drupal\Component\Utility\Html::escape(NULL)
#4 web/core/lib/Drupal/Component/Render/FormattableMarkup.php(232): Drupal\Component\Render\FormattableMarkup::placeholderEscape(NULL)
#5 web/core/lib/Drupal/Core/StringTranslation/TranslatableMarkup.php(195): Drupal\Component\Render\FormattableMarkup::placeholderFormat('%profile_name (...', Array)
#6 web/core/lib/Drupal/Component/Utility/ToStringTrait.php(15): Drupal\Core\StringTranslation\TranslatableMarkup->render()
#7 vendor/drush/drush/src/Drupal/DrupalUtil.php(23): Drupal\Core\StringTranslation\TranslatableMarkup->__toString()
#8 vendor/drush/drush/src/Drupal/Commands/core/DrupalCommands.php(132): Drush\Drupal\DrupalUtil::drushRender(Object(Drupal\Core\StringTranslation\TranslatableMarkup))
#9 [internal function]: Drush\Drupal\Commands\core\DrupalCommands->requirements(Array)
...

I've left a short review in the MR that needs some work

Tried to address #38, changing status to needs review.

We are so close, I still have 2 comments in the MR. Also, @larisse, could you, please, change the base branch of the MR to `11.x`? Thanks

I've updated the existing (MR) with the changes suggested #43. However, I don't have the necessary permissions to edit this MR and change the branch to 11.x. Would it be okay if I create a new MR against the 11.x branch?

Please try to find @larisse and ask her to change. If you don't have a reply in a reasonable amount of time, yes, create a new MR

I removed the unused FormattableMarkup import again.

Left a comment around the test.

To move test, rest seems good to me.

Rebased the branch and moved the tests. Not sure why tests are failing.

Attached also you can fin the patch for Drupal 11.2.2 for composer

Pretty sure this was fixed in #3511868: A profile without a version causes a fatal error on status report page, can anyone confirm? If that's the case a core maintainer can assigned credit and we can close as a duplicate.

Yes, totally a duplicate. Adding it as related issue.

I think RTBC might get more attention from a core maintainer to assign credit

Thanks for figuring out this was a duplicate. Did my best with issue credit and closing out.