Problem/Motivation

#3122763: Replaced deprecated method for drush_log and drush_delete_dir() introduced a change which doesn't use dependency injection, but static service call instead.

$this->renderer is already present, file_url_generator service has to be injected in src/PhotoswipePreprocessProcessor.php

Proposed resolution

Use DI and write a test to ensure functionality isn't broken.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork photoswipe-3270715

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Anybody created an issue. See original summary.

Grevil made their first commit to this issue’s fork.

Grevil opened merge request !26

grevil’s picture

grevil commented
Status: Active » Needs review

Fixed!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Fixed

Very well done, thanks @Grevil!

  • Anybody committed dba8a5b on 3.x authored by Grevil 
    Issue #3270715 by Grevil, Anybody: Use dependency injection for...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.