Prepare Drupal 10 compatibility (planned for August 2022).

Running drupal-check reports:

FILE: tests/src/Functional/BulkFormTest.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 58   Call to deprecated method drupalPostForm() of class         
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.1.0 and
                    is removed from drupal:10.0.0. Use $this->submitForm()      
                    instead.                                                    
--------------------------------------------------------------------------------

FILE: tests/src/Functional/NodeFormTest.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 145  Call to deprecated method drupalPostForm() of class         
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.1.0 and
                    is removed from drupal:10.0.0. Use $this->submitForm()      
                    instead.                                                    
--------------------------------------------------------------------------------
Check manually 189  Call to deprecated method drupalPostForm() of class         
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.1.0 and
                    is removed from drupal:10.0.0. Use $this->submitForm()      
                    instead.                                                    
--------------------------------------------------------------------------------
Check manually 232  Call to deprecated method drupalPostForm() of class         
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.1.0 and
                    is removed from drupal:10.0.0. Use $this->submitForm()      
                    instead.                                                    
--------------------------------------------------------------------------------
Check manually 236  Call to deprecated method drupalPostForm() of class         
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.1.0 and
                    is removed from drupal:10.0.0. Use $this->submitForm()      
                    instead.                                                    
--------------------------------------------------------------------------------
Check manually 240  Call to deprecated method drupalPostForm() of class         
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.1.0 and
                    is removed from drupal:10.0.0. Use $this->submitForm()      
                    instead.                                                    
--------------------------------------------------------------------------------

FILE: override_node_options.info.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 0    Value of core_version_requirement: ^8 || ^9 is not          
                    compatible with the next major version of Drupal core. See  
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

FILE: composer.json

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 0    The drupal/core requirement is not compatible with the next 
                    major version of Drupal. Either remove it or update it to be
                    compatible. See                                             
                    https://drupal.org/node/2514612#s-drupal-9-compatibility.   
--------------------------------------------------------------------------------

Thank's

Issue fork override_node_options-3269901

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

S3b0uN3t created an issue. See original summary.

victoria-marina’s picture

victoria-marina commented
Assigned: Unassigned » victoria-marina

I'll work on this.

victoria-marina opened merge request !1

victoria-marina’s picture

victoria-marina commented
Assigned: victoria-marina » Unassigned
Status: Active » Needs review

Kindly review it.

kimberlly_amaral’s picture

kimberlly_amaral commented
Assigned: Unassigned » kimberlly_amaral

I'll review it.

kimberlly_amaral’s picture

kimberlly_amaral commented
Assigned: kimberlly_amaral » Unassigned
Status: Needs review » Reviewed & tested by the community

I checked the changes and ran drupal-check. I found no errors. So I am changing the status to RTBC.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Status: Reviewed & tested by the community » Needs review
Issue tags: +Needs manual testing

Thanks for reviewing. The module's functionality needs to be tested on Drupal 10. See the following for general instructions:

https://www.drupal.org/community-initiatives/contribution-events-initiat...

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Related issues: +#3297795: Automated Drupal 10 compatibility fixes

Note I see there is another Drupal 10 compatibility issue here:

#3297795: Automated Drupal 10 compatibility fixes

I did not check if there was overlap between these two issues so that should be done. If they are doing the same work, one should be closed out in favor of the other... ideally, keeping the bot issue.

mmjvb’s picture

mmjvb commented
Status: Needs review » Reviewed & tested by the community

Requesting attention of maintainers as I consider this a no-brainer issue.

It only effect the tests of this module, no changes to the module itself. You might want this for 3.x instead.

On commit, you might want to change
/** @var AccountProxyInterface $user */
to
/** @var \Drupal\Core\Session\AccountProxyInterface $user */
to please drupal-check, assuming it doesn't cause other issues.

EDIT This is the issue why the Automated Fix is now Needs work, consider that out of there and too minor for NW here.

awset made their first commit to this issue’s fork.

awset’s picture

awset commented

as per @mmjvb's comment above, I commit the no-brainer issue and fix the other issue related to the return type of the test method.

mmjvb’s picture

mmjvb commented

@awset Thank you. Still RTBC.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented

I see that most of the changes are in the tests and the only other changes are comments or versions.

I will leave as RTBC but, ideally, this would still be tested on Drupal 10 even though it should work in principle. As such, I'm leaving the manual testing tag. See #7.

mmjvb’s picture

mmjvb commented

That would be testing core rather than this module. Suggest to wait for an RC to do that. Nothing to do with D10 compatibility, any issue should be analyzed as for where the bug is: core or module or both. Consider that the normal bug report procedure. Out of scope for this issue!

roaldnel’s picture

roaldnel commented

Thanks for the work you have done on this! Do you maybe have a timeline on when this will be merged by chance?

xem8vfdh’s picture

xem8vfdh commented

thanks for the work, look forward to the release :)

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Issue tags: -Needs manual testing

Removing testing tag since changes are primarily in tests other than info-file changes.

opdavies made their first commit to this issue’s fork.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented

Thanks @opdavies :) Do you want this issue marked Fixed or back to Active in case there are future bot patches?

opdavies’s picture

opdavies
He/him
Primary language English
Location Wales
commented
Status: Reviewed & tested by the community » Fixed

This has been left open long enough, so I'm marking it as fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.