Problem/Motivation
In #3264945: Move quickedit help topics to quickedit module the help topics related to the quickedit module are moved from the Core help_topics module to the Core quickedit module.
In Drupal 10 these help topics will be removed when the whole quickedit module will be removed.
The moved help topics should also be added to this Contrib incarnation of quickedit.
Since the Contrib quickedit module at this point in time should still be a 1-on-1 copy of the Core module, this should be relatively easy. (#FamousLastWords)
Steps to reproduce
Proposed resolution
Remaining tasks
Do stuff
User interface changes
API changes
Data model changes
Issue fork quickedit-3264949
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
spokjeLet's wait until we have the blessing for the layout and wording on the Core issue #3264945: Move quickedit help topics to quickedit module before we do the copy-paste dance.
Comment #3
spokjeBlocker committed, unpostponing.
Comment #5
spokjeComment #6
dwwSweet, thanks! Reviewing now.
Comment #7
dwwDrat, I suck, sorry. I just noticed some problems with this help text, but only one of them is specific to it living in contrib. I think we might want a fast-follow-up for the core issue to fix a few of these points.
Comment #8
dwwLet's fix most of these at #3265492: Fix inaccuracies in quickedit help topic (after the split from settings_tray) and circle back. Thanks/sorry.
Comment #9
spokjeFixed typo
Comment #10
andypostThere's new patch in related issue #3215784-40: [META] Fix up topics to use new help_route_link function
Comment #11
spokjeBlocker #3265492: Fix inaccuracies in quickedit help topic (after the split from settings_tray) is in, unpostponing.
Comment #12
spokjeLet's cut a new release for Quick Edit first, after the removal has landed. The current version here differs quite a lot from the one in Core ATM.
Comment #13
xjm#12 creates a bit of a circular dependency, because we need to remove the QE stuff from Help Topics in order to remove QE from core. So I think we need to do this issue first.
Comment #14
andyposthelp topic will not fail if route is missing, so this issue looks more like about "removing core mentions" in QE topic
Also please include #3215784: [META] Fix up topics to use new help_route_link function
Comment #15
wim leersComment #16
wim leersComment #17
phenaproximaQuick Edit has been removed from core, so I'm thinking that what might be easiest here is to just, like, commit what we have and do any further wordsmithing in a follow-up. Thoughts?
Comment #18
wim leersSounds reasonable to me!
Comment #20
longwaveThis MR was opened before #3265492: Fix inaccuracies in quickedit help topic (after the split from settings_tray) which updated the text to include some of @dww's suggestions from this issue. I have applied the patch from that issue to the MR so it should now be an exact copy of what we have in 9.5.x.
I agree with #17/#18 that any further changes to the text should be done in a followup.
Comment #21
wim leers@phenaproxima: Do you mind reviewing? Then I can commit :)
Comment #22
phenaproximaI checked out the MR branch, and compared it against HEAD of core 9.5.x with this command:
Nothing came up, which would seem to confirm that the files are identical. Therefore, I think this is RTBC.
Comment #23
wim leersLooks like this actually was already committed:
and
🤷♀️
Well, at least @phenaproxima confirmed that what's in the contrib module right now does match upstream!